Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Extensions rather than create new bots #956

Closed
lswith opened this issue Jul 3, 2019 · 5 comments

Comments

@lswith
Copy link

commented Jul 3, 2019

Feature Request

Is your feature request related to a problem? Please describe.
I have found much of the functionality for a bot I require to be in multiple bots. It would be nice to be able to use 1 bot instead of having to install 10 for 1 repository.

Describe the solution you'd like
I suggest that Probot enable extensions rather than creating new bots, as a way for users to get the functionality they require. Each Extension can have its own separate config on a per repository basis.

Describe alternatives you've considered
Installing each bot I wish to use. This is not what I am after.

Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version the docs.
Maybe a screenshot or design?

@issue-label-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

Issue-Label Bot is automatically applying the label enhancement ➕ to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@welcome

This comment has been minimized.

Copy link

commented Jul 3, 2019

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@gr2m

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The idea to combine multiple apps easily into one came up before, but we never came up with a good design. It's not a priority right now, but I’d be interested on if we can come up with a simple API design. I think people should be able to install other probot apps as dependency and then just require them as modules. I wouldn’t try to reinvent the wheel but built upon Node’s existing APIs

@lswith

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

I definitely agree. Looking at prow and how they manage their plugin api for consuming webhooks, I'd say something like there's could work here.

For scope:

  • each plugin has its own configuration file that determines if the plugin is being used or not. If the configuration file is not present, the plugin doesn't run.
  • each plugin simply registers itself on the app for the appropriate webhooks

One more thing to note is that Prow registers a help method for each plugin so that anyone can go to a UI and learn how to configure each plugin.

@stale

This comment has been minimized.

Copy link

commented Sep 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 1, 2019

@stale stale bot closed this Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.