Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeit Now instructions don't appear to work #985

Open
ezyang opened this issue Aug 14, 2019 · 7 comments

Comments

@ezyang
Copy link

commented Aug 14, 2019

Bug Report

Current Behavior

Setup the tutorial application using https://probot.github.io/docs/hello-world/

Follow the https://probot.github.io/docs/deployment/#now instructions to deploy

It fails with:

> Error! Your `package.json` file is missing a `build` property inside the `script` property.
More details: https://zeit.co/docs/v2/advanced/platform/frequently-asked-questions#missing-build-script

Expected behavior/code
It works

Environment

  • Probot version(s): 7.2.0
  • Node/npm version: [e.g. Node 8/npm 5]
MacBook-Pro-116:pytorch-probot ezyang$ node --version
v11.10.1
MacBook-Pro-116:pytorch-probot ezyang$ yarn --version
1.12.1
  • OS: OS X Mojave

@issue-label-bot issue-label-bot bot added the bug 🐞 label Aug 14, 2019

@welcome

This comment has been minimized.

Copy link

commented Aug 14, 2019

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

Issue-Label Bot is automatically applying the label bug 🐞 to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ezyang

This comment has been minimized.

Copy link
Author

commented Aug 14, 2019

After reading some more Zeit docs, it seems that you have to put index.js in the api/ folder

@gr2m

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

I don't think Probot will work with now v2, but it does with v1. The instructions would ideally reflect that. I think the creation of a now.json file is required. We would appreciate a pull requests if you get it to work

@ibakshay

This comment has been minimized.

Copy link

commented Aug 15, 2019

@ezyang I did a small POC by using Zeit Version 2 serverless deployment and It seems to be working fine for me. https://github.com/ibakshay/zeit-serverless-deployment-poc

My Reference and credits : https://github.com/tibdex/probot-serverless-now

GitHub
proof of concept on serverless deployment of probot bot in `Zeit Now` - ibakshay/zeit-serverless-deployment-poc
GitHub
🤖 Probot Wrapper to run GitHub Apps as Lambdas in Zeit's Now 2.0 - tibdex/probot-serverless-now
@gr2m

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Maybe we could document both approaches? We definitely want to make it easier to deploy Probot to a serverless deployment target, having the current process documented will help us understand the current pain points

@ezyang

This comment has been minimized.

Copy link
Author

commented Aug 15, 2019

Up to y'all; in the end I deployed probot to AWS Lambda instead XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.