Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type for `graphql` method #999

Closed
MaximDevoir opened this issue Aug 29, 2019 · 5 comments · Fixed by #1006

Comments

@MaximDevoir
Copy link
Contributor

commented Aug 29, 2019

Type Issue

The specified type for the .graphql method under GitHub API seems to be incorrect.

It's currently set to Promise<GraphQlQueryResponse>. GraphQlQueryResponse states that you will receive a data property and maybe an errors property.

However, graphql.js returns the data property by default.

@welcome

This comment has been minimized.

Copy link

commented Aug 29, 2019

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@issue-label-bot issue-label-bot bot added the bug 🐞 label Aug 29, 2019

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 29, 2019

Issue-Label Bot is automatically applying the label bug 🐞 to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

MaximDevoir added a commit to MaximDevoir/probot that referenced this issue Aug 29, 2019
@gr2m

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Hi @MaximDevoir thank you for the pull request!

We recently migrated https://github.com/octokit/graphql.js to Typescript, so I think we should be able to remove the Typescript definitions altogether from this repository. Could you try that please?

GitHub
GitHub GraphQL API client for browsers and Node. Contribute to octokit/graphql.js development by creating an account on GitHub.

@MaximDevoir MaximDevoir reopened this Aug 30, 2019

@MaximDevoir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

I'll try that.

@probotbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

🎉 This issue has been resolved in version 9.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@probotbot probotbot added the released label Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.