New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On unmark, ignore if stale label has already been removed #70

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@Crunch09
Contributor

Crunch09 commented Oct 22, 2017

Hi,
this catches any 404 error thrown by the GitHub-API when the client tries to remove a label which no longer exists on the specific issue / PR (described in #52 by @bkeepers ). I also added a test file and tried to make it similar to tests from other repos within the probot organization.

@bkeepers

This comment has been minimized.

Member

bkeepers commented Oct 23, 2017

Wow @Crunch09, you even added tests!?! This is great! 😻

@bkeepers bkeepers merged commit 5f4c963 into probot:master Oct 23, 2017

1 check passed

WIP ready for review
Details
@hiimbex

This comment has been minimized.

Member

hiimbex commented Oct 23, 2017

👏🏻👏🏻👏🏻👏🏻🎉🎉

@Crunch09 Crunch09 deleted the Crunch09:ignore-missing-stale-label-on-unmark branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment