Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Submit the package to CRAN #10

Closed
8 tasks done
tbouffard opened this issue Aug 25, 2021 · 17 comments
Closed
8 tasks done

[FEAT] Submit the package to CRAN #10

tbouffard opened this issue Aug 25, 2021 · 17 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 25, 2021

https://cran.r-project.org/
This let users consume our package easily

Release how-to: see https://r-pkgs.org/release.html and https://www.r-bloggers.com/2020/07/how-to-write-your-own-r-package-and-publish-it-on-cran

@tbouffard
Copy link
Member Author

1st submission rejected on 2021-09-02 19:15:14 UTC

package bpmnVisualization_0.1.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210902_115823/Windows/00check.log>
Status: 2 NOTEs
Debian: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210902_115823/Debian/00check.log>
Status: 2 NOTEs



Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210902_115823/>
The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: CRAN incoming feasibility, Result: NOTE
 Maintainer: 'Celine Souchet <celine.souchet@bonitasoft.com>'

 New submission

 Possibly misspelled words in DESCRIPTION:
   BPMN (3:44, 7:66, 7:140)

 Found the following (possibly) invalid file URIs:
   URI: CONTRIBUTING.md
     From: README.md
   URI: CODE_OF_CONDUCT.md
     From: README.md
   URI: LICENSE
     From: README.md

 The Title field should be in title case. Current version is:
 'Visualize process execution data on BPMN diagrams'
 In title case that is:
 'Visualize Process Execution Data on BPMN Diagrams'

 Found the following \keyword or \concept entries
 which likely give several index terms:
   File 'bpmnVisualization-package.Rd':
     \keyword{
       ~~ Optionally other standard keywords, o [TRUNCATED]

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: top-level files, Result: NOTE
 Non-standard file/directory found at top level:
   'doc'

@tbouffard
Copy link
Member Author

tbouffard commented Sep 6, 2021

Resubmit today with #48 commit 85ab8fb

package bpmnVisualization_0.1.0.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.

Log dir: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210906_173137/>
The files will be removed after roughly 7 days.
Installation time in seconds: 21
Check time in seconds: 37
R Under development (unstable) (2021-09-03 r80852)

Pretests results:
Windows: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210906_173137/Windows/00check.log>
Status: 1 NOTE
Debian: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualization_0.1.0_20210906_173137/Debian/00check.log>
Status: 1 NOTE



No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: CRAN incoming feasibility, Result: NOTE
 Maintainer: 'Celine Souchet <*******>'

 New submission

 Possibly misspelled words in DESCRIPTION:
   BPMN (3:44, 7:66, 7:140)

 Found the following \keyword or \concept entries
 which likely give several index terms:
   File 'bpmnVisualization-package.Rd':
     \keyword{
       ~~ Optionally other standard keywords, o [TRUNCATED]

@tbouffard
Copy link
Member Author

Resubmit today with #49 commit 60ea9d6

@tbouffard
Copy link
Member Author

tbouffard commented Sep 13, 2021

Rejected, we need to implement documentation improvements first.

Please always explain all acronyms in the description text.

Please add \value to .Rd files regarding exported methods and explain the functions results in the
documentation.
Please write about the structure of the output (class) and also what the output means. (If a function does not
return a value, please document that too, e.g. \value{No return value, called for side effects} or similar)
Missing Rd-tags:
    bpmnVisualization-shiny.Rd: \value
    display.Rd: \value

Please add small executable examples in your Rd-files if possible, to illustrate the use of the exported
function but also enable automatic testing.


Please fix and resubmit.

@tbouffard tbouffard modified the milestones: 0.1.2, 0.1.3 Mar 30, 2022
@AndreasUntch
Copy link

Hello,
is there already an update when it's possible to install the package from CRAN?
Thanks

bg

@tbouffard
Copy link
Member Author

tbouffard commented Aug 26, 2022

Hi @AndreasUntch and thank you for your interest in our work 😄
We have no ETA for that. The publication on CRAN has been a more complicated task than expected.
We have to double check in details what is missing in our project to be accepted on CRAN.

In the meantime, it is possible to install the package from GitHub (it is documented in the README).
Have you any issue with the installation from GitHub that prevents you from using bpmn-visualization-R? Or maybe you prefer to install all packages from CRAN?

If you have any blocker, please let us know. In this case, we may re-prioritize the CRAN publishing.

@tbouffard tbouffard pinned this issue Aug 30, 2022
@oanesini oanesini modified the milestones: 0.2.0, 0.2.1 Aug 30, 2022
@AndreasUntch
Copy link

Hi @tbouffard,

my company prevents it due to security policies. We're only allowed to extract packages from CRAN.

@tbouffard
Copy link
Member Author

Thanks @AndreasUntch for your feedback.
We plan, @oanesini and I, to start working on this in the coming weeks. I still don't have a resolution date to share at this time, but we'll keep you posted on progress in this ticket.

@tbouffard
Copy link
Member Author

❌ new submission on 2022-10-28, proposed v0.2.1 commit 0ec0a86

Please always explain all acronyms in the description text. -> 'BPMN'

\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user. Does not seem necessary.
Please replace \dontrun with \donttest. -> bpmnVisualization-package.Rd

Please unwrap the examples if they are executable in < 5 sec, or replace
dontrun{} with \donttest{}.

Please fix and resubmit.

@tbouffard
Copy link
Member Author

tbouffard commented Nov 23, 2022

ℹ️ Done 2022-11-23, submission of https://github.com/process-analytics/bpmn-visualization-R/releases/tag/v0.2.2, commit 4231598

@tbouffard
Copy link
Member Author

ℹ️ We have postponed the submission of version 0.2.2.
We will soon resubmit the package with its final name (see #172).

@csouchet csouchet modified the milestones: 0.3.0, 0.3.1 Jan 9, 2023
@tbouffard
Copy link
Member Author

❌ New submission of version 0.3.0 on 2023-01-09 --> rejected

Dear maintainer,

package bpmnVisualizationR_0.3.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualizationR_0.3.0_20230109_175522/Windows/00check.log>
Status: 2 NOTEs
Debian: <https://win-builder.r-project.org/incoming_pretest/bpmnVisualizationR_0.3.0_20230109_175522/Debian/00check.log>
Status: 2 NOTEs



Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/bpmnVisualizationR_0.3.0_20230109_175522/>
The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-windows-x86_64
Check: CRAN incoming feasibility, Result: NOTE
  Maintainer: 'Celine Souchet <****>'

  New submission

  Possibly misspelled words in DESCRIPTION:
    BPMN (3:44, 7:66)
    TypeScript (7:201)
    bpmn (7:182)

  Found the following (possibly) invalid URLs:
    URL: https://process-analytics.github.io/bpmn-visualization-R (moved to https://process-analytics.github.io/bpmn-visualization-R/)
      From: DESCRIPTION
            man/bpmnVisualizationR-package.Rd
      Status: 200
      Message: OK

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: LazyData, Result: NOTE
    'LazyData' is specified without a 'data' directory

Flavor: r-devel-linux-x86_64-debian-gcc
Check: CRAN incoming feasibility, Result: NOTE
  Maintainer: 'Celine Souchet <****>'

  New submission

  Possibly misspelled words in DESCRIPTION:
    BPMN (3:44, 7:66)
    TypeScript (7:201)
    bpmn (7:182)

  Found the following (possibly) invalid URLs:
    URL: https://process-analytics.github.io/bpmn-visualization-R (moved to https://process-analytics.github.io/bpmn-visualization-R/)
      From: DESCRIPTION
            man/bpmnVisualizationR-package.Rd
      Status: 301
      Message: Moved Permanently

@tbouffard
Copy link
Member Author

tbouffard commented Jan 30, 2023

ℹ️ Preparing the submission of v0.3.1, with commit 448385e

@tbouffard
Copy link
Member Author

tbouffard commented Jan 31, 2023

❌ New submission of version 0.3.1 on 2023-01-31 --> rejected

  • 13:43 GMT+1: under manual review

package bpmnVisualizationR_0.3.1.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days.

  • 2023-02-01 11h53 GMT+1 --> rejected
If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year) <doi:...>
authors (year) <arXiv:...>
authors (year, ISBN:...)
or if those are not available: <https:...>
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking. (If you want to add a title as well please put it in
quotes: "Title")

Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'TypeScript'
Please note that package names are case sensitive.

Please fix and resubmit.

@csouchet
Copy link
Member

csouchet commented Feb 20, 2023

New submission of version 0.3.2 on 2023-02-20

  • 03:12 PM GMT+1: under manual review

package bpmnVisualizationR_0.3.2.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days.

  • 2023-02-21 00:28 PM GMT+1

Thanks,
on its way to CRAN.

🎉 🎉 🎉

@csouchet
Copy link
Member

Hi @AndreasUntch,
If you are still interested in bpmnVisualizationR, you can now find it on CRAN 🙂 
Best Regards,
Céline

@tbouffard
Copy link
Member Author

All tasks are completed, so closing this issue.

@tbouffard tbouffard unpinned this issue May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants