feat: compliance rules highlight activities on popover click #85
Conversation
|
♻️ PR Preview b557648 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
src/compliance-rules.js
Outdated
| tippyInstance.popper.addEventListener("mouseover", (event) => { | ||
| if (event.target.nodeName === "TD") { | ||
| const selectedRow = event.target.parentElement; | ||
| selectedRow.style.backgroundColor = "lightgray"; | ||
| const activityName = selectedRow.firstElementChild.textContent; | ||
| const activityId = getElementIdByName(activityName) | ||
| //highlight activity | ||
| bpmnVisualization.bpmnElementsRegistry.addCssClasses(activityId, "cause-violation") | ||
| // workaround for https://github.com/process-analytics/icpm-demo-2022/issues/87 | ||
| if(complianceData.has(activityName)){ | ||
| addRippleCircles(activityId, bpmnVisualization) | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| tippyInstance.popper.addEventListener("mouseout", (event) => { | ||
| if (event.target.nodeName === "TD") { | ||
| const selectedRow = event.target.parentElement; | ||
| selectedRow.style.backgroundColor = ""; | ||
| const activityName = selectedRow.firstElementChild.textContent; | ||
| const activityId = getElementIdByName(activityName) | ||
| //highlight activity | ||
| bpmnVisualization.bpmnElementsRegistry.removeCssClasses(activityId, "cause-violation") | ||
| // workaround for https://github.com/process-analytics/icpm-demo-2022/issues/87 | ||
| if(complianceData.has(activityName)){ | ||
| addRippleCircles(activityId, bpmnVisualization) | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
issue: the highlight of the rows of the popover should be done with CSS directly, as this is done in https://github.com/process-analytics/bonita-day-demo-2023/pull/10/files.
There was a problem hiding this comment.
@assynour did you have time to check the review?
There was a problem hiding this comment.
I will fix it this week
src/compliance-rules.js
Outdated
| tippyInstance.popper.addEventListener("mouseover", (event) => { | ||
| if (event.target.nodeName === "TD") { | ||
| const selectedRow = event.target.parentElement; |
There was a problem hiding this comment.
suggestion: process-analytics/bonita-day-demo-2023#18 registers the event listener directly in the elements of the HTML of the popover. This is easy to register them directly on the rows (TR elements).
There was a problem hiding this comment.
I will take this into account
closes #62