New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Login & Sign Up as modal layovers #122

Merged
merged 3 commits into from Oct 8, 2016

Conversation

2 participants
@yining1023
Member

yining1023 commented Oct 5, 2016

This PR changes Login and Sign Up from separate pages to modal layovers on the main page.

screen shot 2016-10-05 at 3 09 10 pm

screen shot 2016-10-05 at 3 09 29 pm

Show outdated Hide outdated client/routes.js
Show outdated Hide outdated client/styles/components/_login.scss
Show outdated Hide outdated client/styles/components/_signup.scss
Show outdated Hide outdated client/routes.js
Show outdated Hide outdated client/styles/components/_login.scss
Show outdated Hide outdated client/styles/components/_signup.scss
@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Oct 7, 2016

Member

Overall this looks great 😄 and I'm not seeing that React error you were having.

Member

catarak commented Oct 7, 2016

Overall this looks great 😄 and I'm not seeing that React error you were having.

@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Oct 7, 2016

Member

😄 Yay! I just deleted all extra comments, and committed the changes.

Member

yining1023 commented Oct 7, 2016

😄 Yay! I just deleted all extra comments, and committed the changes.

@catarak catarak merged commit 96321ca into processing:master Oct 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment