New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing "Autosave enabled" toast #173

Merged
merged 3 commits into from Oct 27, 2016

Conversation

Projects
None yet
2 participants
@yining1023
Member

yining1023 commented Oct 27, 2016

fixes #159

@@ -16,7 +16,8 @@ const initialState = {
unsavedChanges: false,
infiniteLoop: false,
previewIsRefreshing: false,
infiniteLoopMessage: ''
infiniteLoopMessage: '',
projectJustOpened: false

This comment has been minimized.

@catarak

catarak Oct 27, 2016

Member

and this as well

@catarak

catarak Oct 27, 2016

Member

and this as well

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Oct 27, 2016

Member

Just added a few comments about having consistent naming. I tried to add comments on all the lines you'll need to update so they will be easier not to miss.

Member

catarak commented Oct 27, 2016

Just added a few comments about having consistent naming. I tried to add comments on all the lines you'll need to update so they will be easier not to miss.

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Oct 27, 2016

Member

hmmm I'm getting the error Actions may not have an undefined "type" property. Have you misspelled a constant?

Member

catarak commented Oct 27, 2016

hmmm I'm getting the error Actions may not have an undefined "type" property. Have you misspelled a constant?

@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Oct 27, 2016

Member

So sorry about this. Now it's all good.

Member

yining1023 commented Oct 27, 2016

So sorry about this. Now it's all good.

@catarak catarak merged commit 83b0774 into processing:master Oct 27, 2016

yining1023 added a commit to yining1023/p5.js-web-editor that referenced this pull request Nov 2, 2016

Showing "Autosave enabled" toast (#173)
* showing Autosave enabled toast

* fixed variable names

* fixed constant name typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment