New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for ResetPassword view and NewPassword view #232

Merged
merged 4 commits into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@yining1023
Member

yining1023 commented Dec 17, 2016

This PR includes the following -

  1. made ResetPasswordview and NewPasswordView two separated pages
  2. implemented the new design for resetPassword and newPassword page

I made the exit icon on both pages going to the home page. People can only go to resetPassword page through login page, and if the exit icon leads people back to login page, the exit icon on login page will lead people back to resetPassword page, which would be an endless loop.

I couldn't test the whole functionality about resetting password on my local computer, could you test it again? I just want to make sure I didn't break anything. It should be fine though, I only updated token to this.props.params.reset_password_token in NewPasswordView(instead of getting it from IDEView).
screen shot 2016-12-16 at 6 03 57 pm
screen shot 2016-12-16 at 6 03 38 pm

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Dec 19, 2016

Member

I also noticed the view for /reset-password/<token> doesn't look right:
screen shot 2016-12-19 at 12 53 10 pm

Member

catarak commented Dec 19, 2016

I also noticed the view for /reset-password/<token> doesn't look right:
screen shot 2016-12-19 at 12 53 10 pm

@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Dec 19, 2016

Member

I found that when people go to /reset-password/<token> directly(without going to ideView first), any style with the minxinthemify(){} cannot be injected properly. I think an easy way to fix this it to create styles for theseinput and icon that not rely on themify(), since we don't need different colors on those pages. What do you think?

Member

yining1023 commented Dec 19, 2016

I found that when people go to /reset-password/<token> directly(without going to ideView first), any style with the minxinthemify(){} cannot be injected properly. I think an easy way to fix this it to create styles for theseinput and icon that not rely on themify(), since we don't need different colors on those pages. What do you think?

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Dec 19, 2016

Member

yes, I think that's the right thing to do 😄

Member

catarak commented Dec 19, 2016

yes, I think that's the right thing to do 😄

@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Dec 19, 2016

Member

Cool! Just made some changes, now the styles should be fine.😄

Member

yining1023 commented Dec 19, 2016

Cool! Just made some changes, now the styles should be fine.😄

@catarak catarak merged commit 0f17633 into processing:master Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment