New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Design for About #246

Merged
merged 3 commits into from Jan 6, 2017

Conversation

Projects
None yet
4 participants
@yining1023
Member

yining1023 commented Dec 31, 2016

New design for about page, and Happy New Year! 馃尭
screen shot 2016-12-31 at 11 42 54 am

@lmccart

This comment has been minimized.

Show comment
Hide comment
@lmccart

lmccart Dec 31, 2016

Member

馃帀

Member

lmccart commented Dec 31, 2016

馃帀

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Jan 5, 2017

Member

i am slow and catching up on everything, this looks amazing!

Member

catarak commented Jan 5, 2017

i am slow and catching up on everything, this looks amazing!

@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Jan 5, 2017

Member

One small thing: you don't need to include a smaller play button, you can actually change the size of an SVG in CSS:

.about__play-video-button svg {
  width: #{11 / $base-font-size}rem;
  height: #{11 / $base-font-size}rem;
}
Member

catarak commented Jan 5, 2017

One small thing: you don't need to include a smaller play button, you can actually change the size of an SVG in CSS:

.about__play-video-button svg {
  width: #{11 / $base-font-size}rem;
  height: #{11 / $base-font-size}rem;
}
@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Jan 6, 2017

Member

haha, you are right. I didn't know I could just change its CSS. Just pushed the changes!

Member

yining1023 commented Jan 6, 2017

haha, you are right. I didn't know I could just change its CSS. Just pushed the changes!

@catarak catarak merged commit 62b4d4c into processing:master Jan 6, 2017

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jan 12, 2017

Member

I am just noticing this now, fantastic work!!!

Member

shiffman commented Jan 12, 2017

I am just noticing this now, fantastic work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment