New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding User Settings View #325

Merged
merged 8 commits into from Mar 16, 2017

Conversation

Projects
None yet
2 participants
@yining1023
Member

yining1023 commented Mar 16, 2017

Fixes #248

This pull request -

  • adds My account to the upper-right user menu
  • creates a My account page with username, email, currentPassword, and newPassword.
  • checks if the username and email are in use, if the currentPassword is valid, and if new password is not empty when currentPassword is not empty. If yes, update all user settings.
    screen shot 2017-03-15 at 10 51 24 pmscreen shot 2017-03-15 at 10 49 03 pmscreen shot 2017-03-15 at 11 13 44 pmscreen shot 2017-03-15 at 11 09 48 pm
@catarak

This comment has been minimized.

Show comment
Hide comment
@catarak

catarak Mar 16, 2017

Member

this looks great, you killed it 💃

I noticed that the dropdown styling is a little funky... Log Out has some extra padding to the left and is a different color/has a different hover state. You mind matching it to the other two dropdown items?
screen shot 2017-03-16 at 1 26 16 am

Member

catarak commented Mar 16, 2017

this looks great, you killed it 💃

I noticed that the dropdown styling is a little funky... Log Out has some extra padding to the left and is a different color/has a different hover state. You mind matching it to the other two dropdown items?
screen shot 2017-03-16 at 1 26 16 am

@yining1023

This comment has been minimized.

Show comment
Hide comment
@yining1023

yining1023 Mar 16, 2017

Member

Thank you!☺️

I just fixed the Log out button style.

Member

yining1023 commented Mar 16, 2017

Thank you!☺️

I just fixed the Log out button style.

@catarak catarak merged commit fe6acc9 into processing:master Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment