Skip to content

Conversation

@piyushzingade
Copy link

@piyushzingade piyushzingade commented Nov 29, 2025

Fixes #3733

Description

This PR improves the hover styling of the navbar button. Previously, when hovering over the button, the arrow icon would disappear due to the applied styles. The updated styling ensures the arrow remains visible and consistent with the rest of the UI.

Changes

Before:

Navbar hover before

After:

Navbar hover after
  • Updated the hover state styles for the navbar button.
  • Ensured the arrow icon remains visible on hover.
  • Kept the design consistent with existing navbar styling.

Verification

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely named feature branch and is up to date with the develop branch
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@piyushzingade piyushzingade changed the title fix(ui): Hover state of Back to Editor #3733 fix(ui): Hover state of Back to Editor Nov 29, 2025
@piyushzingade
Copy link
Author

I have fix the issue #3733
@raclim pls review this

@raclim
Copy link
Collaborator

raclim commented Dec 5, 2025

Thanks for trying this issue out!

Although this PR does address the issue at hand, there's a few improvements that could happen here!

  • First, there seems to be a few extra changes in the PR that adjust spacing and also changes the value of the callbackURL in server/config/passport.js. Although the formatting changes could be helpful, we prefer to ensure that the scope of a PR is limited to the specific issue and does not include changes outside of it to organize and keep track of incoming changes. To include these extra changes, it might be best to address them in a separate issue/PR.

  • While the solution does work, it seems to duplicate the .nav__back-icon block a few times to add in the changes. It might be best to check if anything can be edited within the listed classes, such as .nav__item:hover on line 124, to help keep the file organized and work within the existing infrastructure.

As per our Contributor Guidelines, we also try to make sure that issues are first assigned to a contributor before a PR is opened! Since the original issue has a few folks interested and this PR might need further improvement, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to take a look at our other issues!

@raclim raclim closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover state removes the gap between logo block and “Back to Editor” button

2 participants