Skip to content

Restore No Results translation string (used by search)#1382

Merged
ksen0 merged 1 commit into
processing:mainfrom
aashu2006:restore-no-results-string
Apr 29, 2026
Merged

Restore No Results translation string (used by search)#1382
ksen0 merged 1 commit into
processing:mainfrom
aashu2006:restore-no-results-string

Conversation

@aashu2006

Copy link
Copy Markdown
Member

Follows up on #1364.

Restores the No Results translation key in en, ko, and zh-Hans, it was accidentally removed as part of the filter removal, but it's also used by site-wide search, not just the filter.

@aashu2006

Copy link
Copy Markdown
Member Author

Hi @doradocodes @Nwakaego-Ego , please let me know with any suggestion or tweaks if needed. Thanks!

@Nwakaego-Ego

Nwakaego-Ego commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Thank you, @aashu2006. On the main branch, No Results string has been restored and is working correctly. On the 2.0 branch, PR #1383 applies all the same changes cleanly, filter bar removed, header border consistent, and No Results working as expected.

No Results across all languages for both branches:
English: No entries found for that search.
Chinese: 未找到相关条目
Korean: 검색 결과가 없습니다
Spanish: Falls back to English
Hindi: Falls back to English

image image

I went back and checked PR #1377 to understand why Spanish and Hindi were falling back to English. Looking through the files that were changed, the No Results key was never in es.yaml or hi.yaml to begin with, so this is not something this PR introduced. I will open a separate issue for adding the Spanish and Hindi translations.

cc @doradocodes @ksen0

@ksen0
ksen0 merged commit a9d2170 into processing:main Apr 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants