Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide description for WEBGL #3732

Merged
merged 4 commits into from
May 15, 2019
Merged

Conversation

maddyfisher
Copy link
Contributor

Added a description for the WEBGL constant where beginners are able to understand clearly what WEBGL is and why p5.js is using it.

Added a description for the WEBGL constant where beginners are able to understand clearly what WEBGL is and why p5.js is using it.
@welcome
Copy link

welcome bot commented May 8, 2019

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@lmccart
Copy link
Member

lmccart commented May 8, 2019

@maddyfisher looking great so far! my one suggestion is to break this description into two lines for easier reading. something like this:

* One of the two render modes in p5.js: P2D (default renderer) and WEBGL.
* Enables 3D render by introducing the third dimension: Z. 

@maddyfisher
Copy link
Contributor Author

@lmccart yes, I agree, looks much better!

@maddyfisher maddyfisher marked this pull request as ready for review May 14, 2019 23:31
Broke down sentence into 2 lines instead of one.
@lmccart
Copy link
Member

lmccart commented May 15, 2019

@maddyfisher the linter is confusing here. the problem is not actually the periods, it's the single space after the last character (period or not). so Delete "·" in the linter comment actually means delete space.

@lmccart lmccart merged commit 46eb453 into processing:master May 15, 2019
@lmccart
Copy link
Member

lmccart commented May 15, 2019

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants