Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to description Update 2d_primitives.js #3744

merged 2 commits into from
May 20, 2019


Copy link

@BerfinA BerfinA commented May 15, 2019

I added to the description to help clarify how the arc works counter clockwise in terms of pi values.

Copy link

welcome bot commented May 15, 2019

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@@ -106,7 +106,8 @@ p5.prototype._normalizeArcAngles = function(
* origin may be changed with the <a href="#/p5/ellipseMode">ellipseMode()</a> function.<br><br>
* The arc is always drawn clockwise from wherever start falls to wherever stop falls on the ellipse.
* Adding or subtracting TWO_PI to either angle does not change where they fall.
* If both start and stop fall at the same place, a full ellipse will be drawn.
* If both start and stop fall at the same place, a full ellipse will be drawn.Be ware that the the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while removing the extra empty line at the bottom as per @lmccart's suggestion can you also fix the small typo above ie "Be ware" to "Be aware"?Looks good otherwise though thanks!

Copy link
Contributor Author

BerfinA commented May 15, 2019 via email

removed the extra line and corrected the grammar on "be aware".
@lmccart lmccart merged commit 6fac241 into processing:master May 20, 2019
lmccart pushed a commit that referenced this pull request May 20, 2019
Copy link

lmccart commented May 20, 2019

hooray @BerfinA! thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants