Improved the example code for createCamera()!
#5873
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
Thanks for adding comments to the example! I tested it out and noticed that the ground box is leaving trails behind: This was probably happening earlier too but it was hidden because the small cube never moves by so much each frame to make the white part visible from behind its black outlines. Would you mind also moving the |
|
Whoops! Sorry, forgot to commit that in the pull request. |
|
I accidentally ran a code format on my local copy, and "Linting fix number 2." should fix that. I copy-pasted a previous version of the file and re-did the whitespace removal. Let's see how this goes... |
|
ah hmm it looks like the most recent change indented everything by a space so now the whole file appears in the diff. It might be that the easiest fix might be to revert the last two commits and try removing the spaces again? sorry for all the formatting back-and-forth, I can also try getting the formatting back to what it needs to be if that's easier! |
|
I apologize! I tried doing a similar thing earlier (copy-pasting a previous version, making changes and uploading that, as seen in "Linting fix number 2."). Clearly, that did not work. Your help would very-much be appreciated. |
|
No problem 🙂 |
|
@all-contributors please add @Brahvim for doc |
|
I've put up a pull request to add @Brahvim! 🎉 |
|
Gratitudes from my side - thank you a lot, @davepagurek! |
Improved the example code for
createCamera()! There is now a 'ground box' to help any new-to-OpenGL person viewing the scene understand what the camera is doing - moving on thex-axis while also rotating on they-axis to look directly at[0, 0, 0].