Skip to content

Conversation

@VANSH3104
Copy link
Contributor

Resolves #7903

Changes:

Modified ellipse() method in p5.Renderer2D to apply transforms during clipping
Used existing this.initialClipTransform (inverse of initial transform) stored in beginClip()
Applied correct matrix multiplication order: initialClipTransform.multiply(currentTransform)

Screenshots of the change:

Screenshot 2025-11-06 at 1 09 33 PM

PR Checklist

@VANSH3104
Copy link
Contributor Author

@davepagurek I've implemented the manual fix for the ellipse() method and it's working correctly now!
I think moving to the class-based approach you suggested would be better long-term. Should I extend this manual fix to other primitives (rect, arc, etc.) first, or start working on migrating them to the shape system? and also drawshape function is useless i think its never call while clipping on or off

Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function setup() {
  createCanvas(400, 200);
  pixelDensity(1);
  noLoop();
}

function draw() {
  background(240);
  translate(200, 0); 
  clip(() => {
    scale(-1,1);                 
    ellipse(50, 100, 100, 100);  
  });
  fill(0, 0, 255, 120);
  ellipse(100, 100, 300, 300); 
}

what you get when you use this sketch? I think transformation is not correctly applied?

Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your current solution applies to ellipse only? Do you think we need to add this solution in other shapes as well? arc/quad/line etc?

btw, thanks for working on this one.

@VANSH3104
Copy link
Contributor Author

@perminder-17 yes it is only applicable for ellipse now I need to change for all too

@VANSH3104
Copy link
Contributor Author

@perminder-17 I also have another idea class based approach also just want to discuss which one is better. I think This approach is temporary we need to find a perfect solution for that

@VANSH3104
Copy link
Contributor Author

Screenshot 2025-11-12 at 1 32 57 AM it shows this @perminder-17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants