Updated point() examples for visible points. #8291
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Hi @menacingly-coded, thanks for working on this. The issue with point() defaulting to 1px and respecting strokeWeight(1) in WEBGL mode should be fixed on the main branch.
It looks like this behavior is already being addressed in PR #8179.
For now, the PR looks good to me on the docs part so I'll merge this.
Collaborator
|
@all-contributors please add @menacingly-coded for doc |
Author
|
Hi @perminder-17 , Thank you for the update! Sure, I’ll make the necessary changes for the main branch as well. Let me know if there’s anything else you'd like me to adjust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8266
Changes:
There were three examples of point() in the docs which I updated and made them visible as compared to before.
Screenshots of the change:
before:
after:
PR Checklist
npm run lintpasses