Skip to content

do not export unset fields, and set min python version #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

do not export unset fields, and set min python version #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update_contributions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.x
python-version: '>=3.11'

- name: Install dependencies
run: pip install -r requirements.txt
Expand Down
6 changes: 3 additions & 3 deletions scripts/parse_and_validate_properties_txt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,19 @@ def validate_existing(properties_dict):
# validation on existing contribution is weaker
properties = PropertiesExisting.model_validate(properties_dict)

return properties.model_dump()
return properties.model_dump(exclude_unset=True)

def validate_new(properties_dict):
# new contribution has stronger validation
properties = PropertiesBase.model_validate(properties_dict)

return properties.model_dump()
return properties.model_dump(exclude_unset=True)

def validate_new_library(properties_dict):
# new contribution has stronger validation
properties = LibraryPropertiesNew.model_validate(properties_dict)

return properties.model_dump()
return properties.model_dump(exclude_unset=True)

def set_output(output_object):
with open(os.environ['GITHUB_OUTPUT'],'a') as f:
Expand Down