New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeasyCam listed in Contribution manager as version "null" #478

Closed
jeremydouglass opened this Issue Oct 2, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@jeremydouglass
Contributor

jeremydouglass commented Oct 2, 2016

In Processing 3.2.1, Contribution Manager > Libraries lists "Peasycam null" -- "null available" (to install), and, after installing, "null installed."

I would expect a version number, or else (if version-less libraries are allowed) for the Contribution manager to silently omit the "null" from text display.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Oct 3, 2016

Member

That's a bug, probably an issue with the Library properties file. I'll look into it and notify the author, thanks for reporting.

Member

prisonerjohn commented Oct 3, 2016

That's a bug, probably an issue with the Library properties file. I'll look into it and notify the author, thanks for reporting.

@prisonerjohn prisonerjohn self-assigned this Oct 3, 2016

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn
Member

prisonerjohn commented Oct 3, 2016

cc @jdf !

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Oct 7, 2016

Member

Also added an issue so that it doesn't show 'null' in the UI.

Member

benfry commented Oct 7, 2016

Also added an issue so that it doesn't show 'null' in the UI.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 3, 2016

Member

Closing this since it's not a p5 bug; fixed here processing/processing#4696

Member

benfry commented Nov 3, 2016

Closing this since it's not a p5 bug; fixed here processing/processing#4696

@benfry benfry closed this Nov 3, 2016

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf Nov 6, 2016

Contributor

So... I don't have to do anything?

Contributor

jdf commented Nov 6, 2016

So... I don't have to do anything?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 6, 2016

Member

It's an issue in your project, not the processing-docs repo, so it doesn't belong here. (And the bug noted above that was fixed for the next release that was showing null in the UI.)

Your libraries need some updates to follow the guidelines. Full description/expectation for each of the variables in the library.properties is here: https://github.com/processing/processing/wiki/Library-Basics#describing-your-library--libraryproperties

For instance, this error would be caused by PeasyCam not having a version or prettyVersion set properly. But I also see you have an enormous build string in Python Mode where the simple version (i.e. "3.0" or "3019" however you want to do it) should be.

Member

benfry commented Nov 6, 2016

It's an issue in your project, not the processing-docs repo, so it doesn't belong here. (And the bug noted above that was fixed for the next release that was showing null in the UI.)

Your libraries need some updates to follow the guidelines. Full description/expectation for each of the variables in the library.properties is here: https://github.com/processing/processing/wiki/Library-Basics#describing-your-library--libraryproperties

For instance, this error would be caused by PeasyCam not having a version or prettyVersion set properly. But I also see you have an enormous build string in Python Mode where the simple version (i.e. "3.0" or "3019" however you want to do it) should be.

@jdf

This comment has been minimized.

Show comment
Hide comment
@jdf

jdf Nov 7, 2016

Contributor

Thanks, Ben. I believe I've pushed the requisite changes.

Contributor

jdf commented Nov 7, 2016

Thanks, Ben. I believe I've pushed the requisite changes.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 7, 2016

Member

Looks good on my end!

screen shot 2016-11-07 at 11 05 48 am

Member

prisonerjohn commented Nov 7, 2016

Looks good on my end!

screen shot 2016-11-07 at 11 05 48 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment