ECS: make library lookup thread safe

processing · May 3, 2016 · 49823a0 · 49823a0
1 parent 4ac5c02
commit 49823a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/src/processing/app/Mode.java b/app/src/processing/app/Mode.java
@@ -282,7 +282,7 @@ public File getReferenceFolder() {
   public void rebuildLibraryList() {
     //new Exception("Rebuilding library list").printStackTrace(System.out);
     // reset the table mapping imports to libraries
-    importToLibraryTable = new HashMap<String, List<Library>>();
+    HashMap<String, List<Library>> importToLibraryTable = new HashMap<>();
 
     Library core = getCoreLibrary();
     if (core != null) {
@@ -323,6 +323,11 @@ public void rebuildLibraryList() {
     for (Library lib : contribLibraries) {
       lib.addPackageList(importToLibraryTable);
     }
+
+    // Make this Map thread-safe
+    this.importToLibraryTable = Collections.unmodifiableMap(importToLibraryTable);
+
+    base.getEditors().forEach(Editor::librariesChanged);
   }
 
 

diff --git a/java/src/processing/mode/java/pdex/ErrorCheckerService.java b/java/src/processing/mode/java/pdex/ErrorCheckerService.java
@@ -703,7 +703,7 @@ private List<String> buildSketchLibraryClassPath(JavaMode mode,
         .filter(pckg -> !ignorableImport(pckg))
         .map(pckg -> {
           try {
-            return mode.getLibrary(pckg); // TODO: this may not be thread-safe
+            return mode.getLibrary(pckg);
           } catch (SketchException e) {
             return null;
           }