New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException when calling Client.ip() after the connection has been closed #2576

Closed
kfeuz opened this Issue Jun 10, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@kfeuz
Contributor

kfeuz commented Jun 10, 2014

When the ip() method is called after the client connection has been closed a NPE is thrown. I would expect that either the IP addressed the client used while the connection was active would be returned or that Null or an Empty String would be returned. Is there a preference on the return value? Note that there is already an active() method to check if the connection is still valid.

kfeuz added a commit to kfeuz/processing that referenced this issue Jun 10, 2014

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jul 25, 2014

Member

Null should be returned. If the client has disconnected, there's no ip associated with them.

Member

benfry commented Jul 25, 2014

Null should be returned. If the client has disconnected, there's no ip associated with them.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 20, 2014

Member

Fixed in 3.0a5.

Member

benfry commented Nov 20, 2014

Fixed in 3.0a5.

@benfry benfry closed this Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment