Ready to add contributed example packages? #2953

Closed
shiffman opened this Issue Nov 15, 2014 · 50 comments

Comments

Projects
None yet
6 participants
@shiffman
Member

shiffman commented Nov 15, 2014

(moving this discussion from e-mail to github).

@prisonerjohn and @joelmoniz we're ready to start adding example packages to the contributions manager. Looks like this was implemented with #2795 and we just need now for an example category in contributions.txt. Here is my first attempt at making an examples package:

http://shiffman.net/p5/example-packages/natureofcode.txt
http://shiffman.net/p5/example-packages/natureofcode.zip

Also, the window title for the examples should say: "Examples Manager" rather than "Examples-Package Manager".

screen shot 2014-11-15 at 11 53 02 am

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 17, 2014

Member

I just added the NoC examples URL to the contributions list. It looks like this:

examples
category=
minRevision=0
authorList=[Daniel Shiffman](http://shiffman.net)
name=The Nature of Code
maxRevision=0
sentence=All examples from The Nature of Code book.
url=http://natureofcode.com
prettyVersion=1
maxVersion=0
paragraph=How can we capture the unpredictable evolutionary and emergent properties of nature in software? How can understanding the mathematical principles behind our physical world help us to create digital worlds? This book focuses on the programming strategies and techniques behind computer simulations of natural systems using Processing.
version=1
download=http://shiffman.net/p5/example-packages/natureofcode.zip
minVersion=0
id=154

@joelmoniz Let me know if this works. Parsing it should be the same as tools and modes.
@shiffman I'm not registering the category ("Books" in this case). Is this something we want to add for example contributions?

Member

prisonerjohn commented Nov 17, 2014

I just added the NoC examples URL to the contributions list. It looks like this:

examples
category=
minRevision=0
authorList=[Daniel Shiffman](http://shiffman.net)
name=The Nature of Code
maxRevision=0
sentence=All examples from The Nature of Code book.
url=http://natureofcode.com
prettyVersion=1
maxVersion=0
paragraph=How can we capture the unpredictable evolutionary and emergent properties of nature in software? How can understanding the mathematical principles behind our physical world help us to create digital worlds? This book focuses on the programming strategies and techniques behind computer simulations of natural systems using Processing.
version=1
download=http://shiffman.net/p5/example-packages/natureofcode.zip
minVersion=0
id=154

@joelmoniz Let me know if this works. Parsing it should be the same as tools and modes.
@shiffman I'm not registering the category ("Books" in this case). Is this something we want to add for example contributions?

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Nov 17, 2014

Member

I'm not seeing this is the contributions manager yet (but then again I'm on a flight with horrible wifi.) @REAS what do you think about the Books category? My instinct is that it's a good one to have. Or is it better to arrange by topic like "simulation" or "beginner" or . . .?

Member

shiffman commented Nov 17, 2014

I'm not seeing this is the contributions manager yet (but then again I'm on a flight with horrible wifi.) @REAS what do you think about the Books category? My instinct is that it's a good one to have. Or is it better to arrange by topic like "simulation" or "beginner" or . . .?

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Nov 17, 2014

Member

I'm extremely excited about this new feature, more and more as we dig into it. Yes, I thing categories are useful and I think "books" is a good category for Nature of Code and the other books. I'm also not seeing it yet.

Member

REAS commented Nov 17, 2014

I'm extremely excited about this new feature, more and more as we dig into it. Yes, I thing categories are useful and I think "books" is a good category for Nature of Code and the other books. I'm also not seeing it yet.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Nov 17, 2014

Member

The link http://download.processing.org/contribs.txt does not seem to have it listed yet.
Also, as per the present naming convention, it should be "examples-package" rather than "examples" for the Contributions Manager to detect it at present. @prisonerjohn

@shiffman @REAS @fjenett @prisonerjohn : Should I go about renaming the contribution to "example" or "examples" as opposed to "examples-package"?

Member

joelmoniz commented Nov 17, 2014

The link http://download.processing.org/contribs.txt does not seem to have it listed yet.
Also, as per the present naming convention, it should be "examples-package" rather than "examples" for the Contributions Manager to detect it at present. @prisonerjohn

@shiffman @REAS @fjenett @prisonerjohn : Should I go about renaming the contribution to "example" or "examples" as opposed to "examples-package"?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 17, 2014

Member

No, I'll change that on my end and regenerate the files. I'll do this later
today and let you all know when it's up.

On Monday, November 17, 2014, Joel Moniz notifications@github.com wrote:

The link http://download.processing.org/contribs.txt does not seem to
have it listed yet.
Also, as per the present naming convention, it should be
"examples-package" rather than "examples" for the Contributions Manager to
detect it at present. @prisonerjohn https://github.com/prisonerjohn

@shiffman https://github.com/shiffman @REAS https://github.com/REAS
@fjenett https://github.com/fjenett @prisonerjohn
https://github.com/prisonerjohn : Should I go about renaming the
contribution to "example" or "examples" as opposed to "examples-package"?


Reply to this email directly or view it on GitHub
#2953 (comment)
.

Elie Zananiri
@prisonerjohn

Member

prisonerjohn commented Nov 17, 2014

No, I'll change that on my end and regenerate the files. I'll do this later
today and let you all know when it's up.

On Monday, November 17, 2014, Joel Moniz notifications@github.com wrote:

The link http://download.processing.org/contribs.txt does not seem to
have it listed yet.
Also, as per the present naming convention, it should be
"examples-package" rather than "examples" for the Contributions Manager to
detect it at present. @prisonerjohn https://github.com/prisonerjohn

@shiffman https://github.com/shiffman @REAS https://github.com/REAS
@fjenett https://github.com/fjenett @prisonerjohn
https://github.com/prisonerjohn : Should I go about renaming the
contribution to "example" or "examples" as opposed to "examples-package"?


Reply to this email directly or view it on GitHub
#2953 (comment)
.

Elie Zananiri
@prisonerjohn

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 17, 2014

Member

The contrib type should be "examples" instead of "examples-package" or "example".

Member

benfry commented Nov 17, 2014

The contrib type should be "examples" instead of "examples-package" or "example".

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 17, 2014

Member

I just want to confirm we're talking about the same thing when we say "contrib type". Are we talking about the section header in the contribs.txt file?
If so, I believe it should be Example, to follow convention with Library, Tool, and Mode.
If not, what are we talking about?

Member

prisonerjohn commented Nov 17, 2014

I just want to confirm we're talking about the same thing when we say "contrib type". Are we talking about the section header in the contribs.txt file?
If so, I believe it should be Example, to follow convention with Library, Tool, and Mode.
If not, what are we talking about?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 17, 2014

Member

Scratch that, I just read #2954 where you outline the directory structure. Got it :)

Member

prisonerjohn commented Nov 17, 2014

Scratch that, I just read #2954 where you outline the directory structure. Got it :)

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Nov 17, 2014

Member

As per this PR, where I have renamed examples-package to examples, the Nature of Code's examples contribution now shows in the Examples Contributions Manager.

Member

joelmoniz commented Nov 17, 2014

As per this PR, where I have renamed examples-package to examples, the Nature of Code's examples contribution now shows in the Examples Contributions Manager.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Nov 18, 2014

Member

I can confirm that i see the examples package in 233 (not in 3.0a5), but when I try to install it fails and says Could not find a examples in the downloaded file. Is this an issue with how I formatted the examples package or a bug in the contributions manager?

screen shot 2014-11-17 at 7 36 27 pm

Member

shiffman commented Nov 18, 2014

I can confirm that i see the examples package in 233 (not in 3.0a5), but when I try to install it fails and says Could not find a examples in the downloaded file. Is this an issue with how I formatted the examples package or a bug in the contributions manager?

screen shot 2014-11-17 at 7 36 27 pm

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Nov 18, 2014

Member

Ah yes... Sorry. That might be because it is searching for a different directory structure because of the renaming. Could you please change the structure to:

/natureofcode/examples/chapter1/
/natureofcode/examples/chapter2/

etc.

/natureofcode/examples.properties/

Thanks

Member

joelmoniz commented Nov 18, 2014

Ah yes... Sorry. That might be because it is searching for a different directory structure because of the renaming. Could you please change the structure to:

/natureofcode/examples/chapter1/
/natureofcode/examples/chapter2/

etc.

/natureofcode/examples.properties/

Thanks

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 18, 2014

Member

I noticed a problem that will arise when we start adding example packages.

In this snippet of code, the contribution parser stops in its tracks if it finds an invalid contribution. The ContributionType.fromName() method was just changed to accept examples instead of examples-package. That means that once we start adding examples to the list of contributions, anybody running a revision older than 233 will have their list missing entries (any entries following the first example entry).

I guess it's not such a big deal to break older alpha releases, but it's still something to be aware of. I removed the Nature of Code contribution for the time being, but can add it back.

Member

prisonerjohn commented Nov 18, 2014

I noticed a problem that will arise when we start adding example packages.

In this snippet of code, the contribution parser stops in its tracks if it finds an invalid contribution. The ContributionType.fromName() method was just changed to accept examples instead of examples-package. That means that once we start adding examples to the list of contributions, anybody running a revision older than 233 will have their list missing entries (any entries following the first example entry).

I guess it's not such a big deal to break older alpha releases, but it's still something to be aware of. I removed the Nature of Code contribution for the time being, but can add it back.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Nov 18, 2014

Member

oops! Thanks @joelmoniz I had made this change, but not pushed it to shiffman.net. New zip should be there now.

Member

shiffman commented Nov 18, 2014

oops! Thanks @joelmoniz I had made this change, but not pushed it to shiffman.net. New zip should be there now.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Nov 18, 2014

Member

@prisonerjohn do you mean this breaks the ability to install anything including libraries or modes in previous 3.0a releases? If it's only that example packages won't work from now on that is definitely ok I think. We have this situation with processing-video cannot be installed with 3.0a3 but can for 3.0a4 for example.

Member

shiffman commented Nov 18, 2014

@prisonerjohn do you mean this breaks the ability to install anything including libraries or modes in previous 3.0a releases? If it's only that example packages won't work from now on that is definitely ok I think. We have this situation with processing-video cannot be installed with 3.0a3 but can for 3.0a4 for example.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Nov 18, 2014

Member

Oh my. Yes, it seems this change would break the contributions manager for all processing versions in which the link was changed from contributions.txt to contribs.txt. The only reasonable solution I can think of is to search for examples-packages in the contribs.txt, but to use examples everywhere else, although I'm not quite sure how elegant this solution would be. But the thing is, wouldn't including the new contribution type in itself break a few older alpha versions already?

Member

joelmoniz commented Nov 18, 2014

Oh my. Yes, it seems this change would break the contributions manager for all processing versions in which the link was changed from contributions.txt to contribs.txt. The only reasonable solution I can think of is to search for examples-packages in the contribs.txt, but to use examples everywhere else, although I'm not quite sure how elegant this solution would be. But the thing is, wouldn't including the new contribution type in itself break a few older alpha versions already?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Nov 18, 2014

Member

@shiffman That's right. I learned this the hard way yesterday when the video library disappeared from the list :)
@joelmoniz I think you're right, since that snippet returns as soon as it fails instead of just skipping the entry.

Member

prisonerjohn commented Nov 18, 2014

@shiffman That's right. I learned this the hard way yesterday when the video library disappeared from the list :)
@joelmoniz I think you're right, since that snippet returns as soon as it fails instead of just skipping the entry.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 18, 2014

Member

Examples weren't in the 2.x stuff, so they can be left out of contributions.txt.

Do examples packages work in any of the alphas? Just alpha 4 and 5?

Member

benfry commented Nov 18, 2014

Examples weren't in the 2.x stuff, so they can be left out of contributions.txt.

Do examples packages work in any of the alphas? Just alpha 4 and 5?

@shiffman shiffman referenced this issue in processing/processing-docs Nov 22, 2014

Closed

Make Wiki page for Examples Package #173

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jan 28, 2015

Member

What's the status of this? I'm ready to work on some example packages as well as put together some documentation (see: processing/processing-docs#173).

Member

shiffman commented Jan 28, 2015

What's the status of this? I'm ready to work on some example packages as well as put together some documentation (see: processing/processing-docs#173).

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jan 28, 2015

Member

Examples work well now. But it seems the contribs.txt doesn't contain The Nature of Code examples package any more, although things worked perfectly when it was there some time ago.

Member

joelmoniz commented Jan 28, 2015

Examples work well now. But it seems the contribs.txt doesn't contain The Nature of Code examples package any more, although things worked perfectly when it was there some time ago.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jan 28, 2015

Member

I think the issue was that if we add it to contribs.txt then previous alphas break. My question would be does this include a5. If it breaks a5 then let's wait until a6 is released and add it in. @prisonerjohn can you shed any light? Let's make sure we double-check that it works before the next release as it would be great to start getting these packages in there.

Member

shiffman commented Jan 28, 2015

I think the issue was that if we add it to contribs.txt then previous alphas break. My question would be does this include a5. If it breaks a5 then let's wait until a6 is released and add it in. @prisonerjohn can you shed any light? Let's make sure we double-check that it works before the next release as it would be great to start getting these packages in there.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jan 28, 2015

Member

Yes, adding any example packages would break previous versions, including a5.

The issue, as detailed in my comment above, is that the Contribution Manager will fail if it receives a contribution type other than "library", "tool", "mode", or "examples-package" for any version of Processing released to date. However, "examples-package" was changed to "examples" soon after the a5 release, so adding an "examples" contribution would break all releases out there.

We should definitely wait until a6 is released before adding any "examples" contributions.

Also, I strongly suggest we change the return statement here to something like a continue in order to avoid this problem with future releases.

Member

prisonerjohn commented Jan 28, 2015

Yes, adding any example packages would break previous versions, including a5.

The issue, as detailed in my comment above, is that the Contribution Manager will fail if it receives a contribution type other than "library", "tool", "mode", or "examples-package" for any version of Processing released to date. However, "examples-package" was changed to "examples" soon after the a5 release, so adding an "examples" contribution would break all releases out there.

We should definitely wait until a6 is released before adding any "examples" contributions.

Also, I strongly suggest we change the return statement here to something like a continue in order to avoid this problem with future releases.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 28, 2015

Member

Thanks for the clarification @prisonerjohn. Given that information, I think we release a6 without adding the examples type (since a5 is actually quite 'stable'). Once we know a6 is behaving (or we make fixes and release a7), we can make this change, or we can wait until a future alpha.

Member

benfry commented Jan 28, 2015

Thanks for the clarification @prisonerjohn. Given that information, I think we release a6 without adding the examples type (since a5 is actually quite 'stable'). Once we know a6 is behaving (or we make fixes and release a7), we can make this change, or we can wait until a future alpha.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jan 29, 2015

Member

A possible way out might be to include the new examples type at the very end of the contributions.txt. That way, as per this part of the code @prisonerjohn highlighted, as soon as the examples tag is encountered, the code would return with list of available contributions, which would be everything except those contributions listed after the first examples line (which again would be only other examples). I've tested this out, and it seems to be running as expected, without any hiccups. Would this have any possible drawbacks?

As a side note, we could, perhaps, have our cake and eat it too. If we replaced the return statement @prisonerjohn highlighted with a continue, and incorporate it into the a6 release, we could have a contributions file as follows:

library/tool/mode
<details>

library/tool/mode
<details>

.
.
.

examples-package
<details of example_package_1>

examples-package
<details of example_package_2>

examples-package
<details of example_package_3>

.
.
.

examples
<details of example_package_1>

examples
<details of example_package_2>

examples
<details of example_package_2>
.
.
.

This way, since a5 and previous alpha releases worked with the examples-package type, and since (if this change is incorporated) a6 will be able to skip contribution names it doesn't recognize, listing things in the above order should enable examples to be used in (hopefully) all versions of alpha releases of processing that support examples (irrespective of how they were named), and not affect the contributions listing of any releases of processing before that.

Should I submit a PR with this proposed change?

Member

joelmoniz commented Jan 29, 2015

A possible way out might be to include the new examples type at the very end of the contributions.txt. That way, as per this part of the code @prisonerjohn highlighted, as soon as the examples tag is encountered, the code would return with list of available contributions, which would be everything except those contributions listed after the first examples line (which again would be only other examples). I've tested this out, and it seems to be running as expected, without any hiccups. Would this have any possible drawbacks?

As a side note, we could, perhaps, have our cake and eat it too. If we replaced the return statement @prisonerjohn highlighted with a continue, and incorporate it into the a6 release, we could have a contributions file as follows:

library/tool/mode
<details>

library/tool/mode
<details>

.
.
.

examples-package
<details of example_package_1>

examples-package
<details of example_package_2>

examples-package
<details of example_package_3>

.
.
.

examples
<details of example_package_1>

examples
<details of example_package_2>

examples
<details of example_package_2>
.
.
.

This way, since a5 and previous alpha releases worked with the examples-package type, and since (if this change is incorporated) a6 will be able to skip contribution names it doesn't recognize, listing things in the above order should enable examples to be used in (hopefully) all versions of alpha releases of processing that support examples (irrespective of how they were named), and not affect the contributions listing of any releases of processing before that.

Should I submit a PR with this proposed change?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jan 29, 2015

Member

@joelmoniz Just to be clear, in your proposed change we would include each example twice in the contribs file, once under the examples-package category and once under the examples category?

Member

prisonerjohn commented Jan 29, 2015

@joelmoniz Just to be clear, in your proposed change we would include each example twice in the contribs file, once under the examples-package category and once under the examples category?

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jan 29, 2015

Member

Exactly. This isn't the neatest of solutions, but it should work. Are there
any possible drawbacks to this proposal, or some error that might crop up
that I might have missed out?

Member

joelmoniz commented Jan 29, 2015

Exactly. This isn't the neatest of solutions, but it should work. Are there
any possible drawbacks to this proposal, or some error that might crop up
that I might have missed out?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 29, 2015

Member

Nah, the alpha releases are truly "alpha" releases. We shouldn't be supporting them or making changes to keep backwards compatibility with them.

The staged rollout I described is just so that we don't blow up a very useful version (3.0a5) with a version that may not be all steps forward (3.0a6). Once we know that 3.0a6 is working, we'll switch to 3.0a6 (or later) and not look back.

Member

benfry commented Jan 29, 2015

Nah, the alpha releases are truly "alpha" releases. We shouldn't be supporting them or making changes to keep backwards compatibility with them.

The staged rollout I described is just so that we don't blow up a very useful version (3.0a5) with a version that may not be all steps forward (3.0a6). Once we know that 3.0a6 is working, we'll switch to 3.0a6 (or later) and not look back.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jan 30, 2015

Member

Ah yes, alright. Would listing examples after tools/libraries/modes be
helpful to prevent breaking 2.0's contribution manager, however?

Member

joelmoniz commented Jan 30, 2015

Ah yes, alright. Would listing examples after tools/libraries/modes be
helpful to prevent breaking 2.0's contribution manager, however?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jan 30, 2015

Member

The 2.x contrib manager reads a different file, doesn't it? (To fix this issue, in fact?)

Member

benfry commented Jan 30, 2015

The 2.x contrib manager reads a different file, doesn't it? (To fix this issue, in fact?)

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jan 30, 2015

Member

Yes, 2.x uses a different file, mostly to filter out incompatible or pre-included libraries (like video and sound). The issue here really only touches the alpha 3.x releases.

Member

prisonerjohn commented Jan 30, 2015

Yes, 2.x uses a different file, mostly to filter out incompatible or pre-included libraries (like video and sound). The issue here really only touches the alpha 3.x releases.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jan 30, 2015

Member

Oops, yes. Sorry, it slipped my mind.

Member

joelmoniz commented Jan 30, 2015

Oops, yes. Sorry, it slipped my mind.

joelmoniz added a commit to joelmoniz/processing that referenced this issue Feb 27, 2015

joelmoniz added a commit to joelmoniz/processing that referenced this issue Feb 27, 2015

joelmoniz added a commit to joelmoniz/processing that referenced this issue Feb 27, 2015

joelmoniz added a commit to joelmoniz/processing that referenced this issue Feb 27, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 22, 2015

Member

Ok, I think we're ready to move ahead on this for the new contribs.txt used by 3.0. Will the change break 3.0a5? Regardlesss, I think we should move forward with it. We need to move on from a5 and a11 should get us there.

And as mentioned in that other post, it should be examples not examples-package for all relevant places that a file/tag/whatever is used.

Member

benfry commented Jun 22, 2015

Ok, I think we're ready to move ahead on this for the new contribs.txt used by 3.0. Will the change break 3.0a5? Regardlesss, I think we should move forward with it. We need to move on from a5 and a11 should get us there.

And as mentioned in that other post, it should be examples not examples-package for all relevant places that a file/tag/whatever is used.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jun 22, 2015

Member

Ok, I have redone my examples package, hopefully correctly. It's quite possible I made a mistake. Here are the new URLs for contribs.txt.

http://shiffman.net/p5/examples/natureofcode.txt
http://shiffman.net/p5/examples/natureofcode.zip

Member

shiffman commented Jun 22, 2015

Ok, I have redone my examples package, hopefully correctly. It's quite possible I made a mistake. Here are the new URLs for contribs.txt.

http://shiffman.net/p5/examples/natureofcode.txt
http://shiffman.net/p5/examples/natureofcode.zip

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jun 22, 2015

Member

@shiffman : Could you please change the structure to:

/natureofcode/examples/chapter1/
/natureofcode/examples/chapter2/

etc.

/natureofcode/examples.properties/

Everything looks perfect once this is done :) :

image

Member

joelmoniz commented Jun 22, 2015

@shiffman : Could you please change the structure to:

/natureofcode/examples/chapter1/
/natureofcode/examples/chapter2/

etc.

/natureofcode/examples.properties/

Everything looks perfect once this is done :) :

image

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jun 22, 2015

Member

changed! (i think). Let me know if I've done it correctly.

Member

shiffman commented Jun 22, 2015

changed! (i think). Let me know if I've done it correctly.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jun 22, 2015

Member

Thanks! Looks fantastic :)

Member

joelmoniz commented Jun 22, 2015

Thanks! Looks fantastic :)

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 22, 2015

Member

Cool, Also, authorList has now changed to authors (though authorList still works to keep compatibility)

Member

benfry commented Jun 22, 2015

Cool, Also, authorList has now changed to authors (though authorList still works to keep compatibility)

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jun 22, 2015

Member

got it, fixing for whenever i do an update (but won't bother to reupload now)

Member

shiffman commented Jun 22, 2015

got it, fixing for whenever i do an update (but won't bother to reupload now)

shiffman added a commit to shiffman/The-Nature-of-Code-Examples that referenced this issue Jun 22, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 23, 2015

Member

With the PR from @joelmoniz, are we all clear to close this one?

Member

benfry commented Jun 23, 2015

With the PR from @joelmoniz, are we all clear to close this one?

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jun 24, 2015

Member

I'm not seeing the nature of code examples show up in 238 (built from source). I deleted contribs.txt and restarted just in case. Did I miss something?

Member

shiffman commented Jun 24, 2015

I'm not seeing the nature of code examples show up in 238 (built from source). I deleted contribs.txt and restarted just in case. Did I miss something?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 24, 2015

Member

Oh, maybe @prisonerjohn still needs to turn them on in contribs.txt.

Member

benfry commented Jun 24, 2015

Oh, maybe @prisonerjohn still needs to turn them on in contribs.txt.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jun 25, 2015

Member

I do, and will do that today.

On Wednesday, June 24, 2015, Ben Fry notifications@github.com wrote:

Oh, maybe @prisonerjohn https://github.com/prisonerjohn still needs to
turn them on in contribs.txt.


Reply to this email directly or view it on GitHub
#2953 (comment)
.

Elie Zananiri
@prisonerjohn

Member

prisonerjohn commented Jun 25, 2015

I do, and will do that today.

On Wednesday, June 24, 2015, Ben Fry notifications@github.com wrote:

Oh, maybe @prisonerjohn https://github.com/prisonerjohn still needs to
turn them on in contribs.txt.


Reply to this email directly or view it on GitHub
#2953 (comment)
.

Elie Zananiri
@prisonerjohn

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 25, 2015

Member

Thanks Elie, that'd be great.

Member

benfry commented Jun 25, 2015

Thanks Elie, that'd be great.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jun 26, 2015

Member

Ok just added Dan's NoC examples and they're showing up in the Contribution Manager. I was able to install the package successfully but it's not showing up in the list. Am I looking in the right place? (Running 3.0a10)

screen shot 2015-06-25 at 8 11 12 pm

Member

prisonerjohn commented Jun 26, 2015

Ok just added Dan's NoC examples and they're showing up in the Contribution Manager. I was able to install the package successfully but it's not showing up in the list. Am I looking in the right place? (Running 3.0a10)

screen shot 2015-06-25 at 8 11 12 pm

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jun 26, 2015

Member

I think that's because of #3429. The examples contribution (or any other contribution, actually) gets downloaded successfully, but doesn't install.

Member

joelmoniz commented Jun 26, 2015

I think that's because of #3429. The examples contribution (or any other contribution, actually) gets downloaded successfully, but doesn't install.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Jun 26, 2015

Member

I can confirm that I'm seeing an "error during installation"

screen shot 2015-06-26 at 6 11 59 am

Member

shiffman commented Jun 26, 2015

I can confirm that I'm seeing an "error during installation"

screen shot 2015-06-26 at 6 11 59 am

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jun 27, 2015

Member

#3429 has been closed. @Akarshit could you test this? I wonder if something broke with the Examples installer during the process of creating the unified CM window.

Member

alignedleft commented Jun 27, 2015

#3429 has been closed. @Akarshit could you test this? I wonder if something broke with the Examples installer during the process of creating the unified CM window.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 5, 2015

Member

Where are we on this, folks?

Member

benfry commented Aug 5, 2015

Where are we on this, folks?

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Aug 5, 2015

Member

I believe this particular issue can be closed, however there is still #3420 to resolve before I can really test.

Member

shiffman commented Aug 5, 2015

I believe this particular issue can be closed, however there is still #3420 to resolve before I can really test.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 25, 2015

Member

#3420 is all set, are we done here?

Member

benfry commented Aug 25, 2015

#3420 is all set, are we done here?

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Aug 25, 2015

Member

I believe so, yes. Closing.

Member

shiffman commented Aug 25, 2015

I believe so, yes. Closing.

@shiffman shiffman closed this Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment