New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encodings, line endings, and mime types in the repo #2955

Closed
benfry opened this Issue Nov 15, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@benfry
Member

benfry commented Nov 15, 2014

Some files are marked as binary that should not be, others should be marked as text, so that the native line ending is used when the file is checked out. Someone just needs to do the work of going through the repo and cleaning things up.

For instance, all .java files should be 1) not marked executable and 2) be plain text, so that the native platform's line endings are used. At the moment, files developed by Windows users (i.e. processing.app.contrib) often have DOS line endings, which shouldn't be happening at all.

@benfry benfry added the help wanted label Nov 15, 2014

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 20, 2014

Member

For instance, because native line endings are not used, build.xml sometimes fails on Windows:
http://forum.processing.org/one/topic/building-processing-from-source-windows.html

Member

benfry commented Nov 20, 2014

For instance, because native line endings are not used, build.xml sometimes fails on Windows:
http://forum.processing.org/one/topic/building-processing-from-source-windows.html

@kfeuz

This comment has been minimized.

Show comment
Hide comment
@kfeuz

kfeuz Nov 20, 2014

Contributor

I have submitted a pull request ( #2977 ) which unsets the executable bit for most files. There are a few remaining files which I was unsure about. They are listed here. The files that clearly should be executable are not in this list.

./java/application/template.app/Contents/PkgInfo
./java/application/template.app/Contents/MacOS/JavaApplicationStub
./java/application/launch4j/bin/windres-macosx
./java/application/launch4j/bin/ld-macosx
./java/application/launch4j/bin/ld-linux
./java/application/launch4j/bin/windres-linux
./java/libraries/serial/library/macosx/libjSSC-2.8.jnilib
./build/macosx/language_gen.py
./pdex/application/template.app/Contents/PkgInfo
./pdex/application/template.app/Contents/MacOS/JavaApplicationStub
./pdex/application/template.plist
./pdex/application/template.exe
./pdex/src/processing/mode/experimental/VariableInspector.form
./app/lib/org-netbeans-swing-outline.jar
./core/src/japplemenubar/libjAppleMenuBar.jnilib

Contributor

kfeuz commented Nov 20, 2014

I have submitted a pull request ( #2977 ) which unsets the executable bit for most files. There are a few remaining files which I was unsure about. They are listed here. The files that clearly should be executable are not in this list.

./java/application/template.app/Contents/PkgInfo
./java/application/template.app/Contents/MacOS/JavaApplicationStub
./java/application/launch4j/bin/windres-macosx
./java/application/launch4j/bin/ld-macosx
./java/application/launch4j/bin/ld-linux
./java/application/launch4j/bin/windres-linux
./java/libraries/serial/library/macosx/libjSSC-2.8.jnilib
./build/macosx/language_gen.py
./pdex/application/template.app/Contents/PkgInfo
./pdex/application/template.app/Contents/MacOS/JavaApplicationStub
./pdex/application/template.plist
./pdex/application/template.exe
./pdex/src/processing/mode/experimental/VariableInspector.form
./app/lib/org-netbeans-swing-outline.jar
./core/src/japplemenubar/libjAppleMenuBar.jnilib

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 20, 2014

Member

These can have their exec bits removed

./java/application/template.app/Contents/PkgInfo
./pdex/application/template.app/Contents/PkgInfo
./pdex/application/template.plist
./app/lib/org-netbeans-swing-outline.jar
./pdex/src/processing/mode/experimental/VariableInspector.form

These should not

./java/application/template.app/Contents/MacOS/JavaApplicationStub
./java/application/launch4j/bin/windres-macosx
./java/application/launch4j/bin/ld-macosx
./java/application/launch4j/bin/ld-linux
./java/application/launch4j/bin/windres-linux
./build/macosx/language_gen.py
./pdex/application/template.app/Contents/MacOS/JavaApplicationStub
./pdex/application/template.exe

These I'm not sure, but let's keep them exec

./java/libraries/serial/library/macosx/libjSSC-2.8.jnilib
./core/src/japplemenubar/libjAppleMenuBar.jnilib
Member

benfry commented Nov 20, 2014

These can have their exec bits removed

./java/application/template.app/Contents/PkgInfo
./pdex/application/template.app/Contents/PkgInfo
./pdex/application/template.plist
./app/lib/org-netbeans-swing-outline.jar
./pdex/src/processing/mode/experimental/VariableInspector.form

These should not

./java/application/template.app/Contents/MacOS/JavaApplicationStub
./java/application/launch4j/bin/windres-macosx
./java/application/launch4j/bin/ld-macosx
./java/application/launch4j/bin/ld-linux
./java/application/launch4j/bin/windres-linux
./build/macosx/language_gen.py
./pdex/application/template.app/Contents/MacOS/JavaApplicationStub
./pdex/application/template.exe

These I'm not sure, but let's keep them exec

./java/libraries/serial/library/macosx/libjSSC-2.8.jnilib
./core/src/japplemenubar/libjAppleMenuBar.jnilib
@kfeuz

This comment has been minimized.

Show comment
Hide comment
@kfeuz

kfeuz Nov 21, 2014

Contributor

Okay. I have unset the executable bit on the suggested files and updated the pull request.

Contributor

kfeuz commented Nov 21, 2014

Okay. I have unset the executable bit on the suggested files and updated the pull request.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 21, 2014

Member

Thanks, though it looks like the PR needs to be updated. It says I need to do a command line merge (oddly, it was saying that even before I merged #2978), which either means 1) it needs and update, or 2) if github will never automatically merge permissions changes like this, it'd probably be faster to just have a list of the files to have -x applied and I can do it manually.

Member

benfry commented Nov 21, 2014

Thanks, though it looks like the PR needs to be updated. It says I need to do a command line merge (oddly, it was saying that even before I merged #2978), which either means 1) it needs and update, or 2) if github will never automatically merge permissions changes like this, it'd probably be faster to just have a list of the files to have -x applied and I can do it manually.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Nov 22, 2014

Member

And closing this out with #2977

Member

benfry commented Nov 22, 2014

And closing this out with #2977

@benfry benfry closed this Nov 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment