New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after creating a tab, must switch to another before opening the new tab #3099

Closed
AlexLardschneider opened this Issue Feb 7, 2015 · 11 comments

Comments

Projects
None yet
6 participants
@AlexLardschneider

AlexLardschneider commented Feb 7, 2015

When you create a new Tab you have to switch to another Tab before you can open the one you just created.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Feb 7, 2015

Member

Which version of Processing are you using?

Member

REAS commented Feb 7, 2015

Which version of Processing are you using?

@AlexLardschneider

This comment has been minimized.

Show comment
Hide comment

AlexLardschneider commented Mar 1, 2015

3.0a5

@StanLepunK

This comment has been minimized.

Show comment
Hide comment
@StanLepunK

StanLepunK Mar 1, 2015

I confirm this problem with P305 on OSX

StanLepunK commented Mar 1, 2015

I confirm this problem with P305 on OSX

@benfry benfry changed the title from Problem when creating new Tab to after creating a tab, must switch to another before opening the new tab Apr 2, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 2, 2015

Member

I can't reproduce this. The new tab should be the frontmost tab right after it's created, and that's what I'm seeing. What am I missing?

Member

benfry commented Apr 2, 2015

I can't reproduce this. The new tab should be the frontmost tab right after it's created, and that's what I'm seeing. What am I missing?

@Plastix

This comment has been minimized.

Show comment
Hide comment
@Plastix

Plastix Apr 5, 2015

Contributor

I can't reproduce this either. When I make a new tab PDE automatically switches to it.

Contributor

Plastix commented Apr 5, 2015

I can't reproduce this either. When I make a new tab PDE automatically switches to it.

@AlexLardschneider

This comment has been minimized.

Show comment
Hide comment
@AlexLardschneider

AlexLardschneider Apr 5, 2015

Creating a new tab in 3.0a5 on OS X 10.10 does not switch to it and you can't click on it. You have to switch to another tab first and then to the newly created one to use it.

AlexLardschneider commented Apr 5, 2015

Creating a new tab in 3.0a5 on OS X 10.10 does not switch to it and you can't click on it. You have to switch to another tab first and then to the newly created one to use it.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 5, 2015

Member

I suspect this is a bug with repaint() not being called, or not being called correctly (i.e. not in sync w/ the EDT), and therefore a threading issue. That's why it's showing up on some machines and not others. The issue is that it's changed to that tab, but the screen hasn't updated. Clicking the tab again doesn't do anything because the code thinks it's already there.

Member

benfry commented Apr 5, 2015

I suspect this is a bug with repaint() not being called, or not being called correctly (i.e. not in sync w/ the EDT), and therefore a threading issue. That's why it's showing up on some machines and not others. The issue is that it's changed to that tab, but the screen hasn't updated. Clicking the tab again doesn't do anything because the code thinks it's already there.

@benfry benfry added the help wanted label Apr 5, 2015

@AlexLardschneider

This comment has been minimized.

Show comment
Hide comment
@AlexLardschneider

AlexLardschneider Apr 6, 2015

But also the code window displays the code from the previous tab, and not a white empty tab.

AlexLardschneider commented Apr 6, 2015

But also the code window displays the code from the previous tab, and not a white empty tab.

@Plastix

This comment has been minimized.

Show comment
Hide comment
@Plastix

Plastix Apr 6, 2015

Contributor

@AlexLardschneider have you you tried running from source?

Contributor

Plastix commented Apr 6, 2015

@AlexLardschneider have you you tried running from source?

@AlexLardschneider

This comment has been minimized.

Show comment
Hide comment
@AlexLardschneider

AlexLardschneider Apr 6, 2015

No I haven't tried that

AlexLardschneider commented Apr 6, 2015

No I haven't tried that

@aengelke

This comment has been minimized.

Show comment
Hide comment
@aengelke

aengelke Aug 6, 2015

Contributor

Some analysis: This happens, whenever the new tab is inserted before the current tab. In the sketch instance stores an index of the active tab, and doesn't update it whenever a new tab is inserted. Therefore, it thinks that the current tab is the new tab from the index, but it is not from the sketch code instance (which is used to determine the active tab elsewhere in the code).

Currently preparing a PR which fixes this.

Contributor

aengelke commented Aug 6, 2015

Some analysis: This happens, whenever the new tab is inserted before the current tab. In the sketch instance stores an index of the active tab, and doesn't update it whenever a new tab is inserted. Therefore, it thinks that the current tab is the new tab from the index, but it is not from the sketch code instance (which is used to determine the active tab elsewhere in the code).

Currently preparing a PR which fixes this.

aengelke added a commit to aengelke/processing that referenced this issue Aug 6, 2015

@benfry benfry closed this in #3540 Aug 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment