New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a progress bar to show progress when the contributions.txt file is being downloaded #3160

Closed
joelmoniz opened this Issue Mar 27, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@joelmoniz
Member

joelmoniz commented Mar 27, 2015

It would be nice to have a progress bar to show how much of the contributions.txt file has completed being downloaded. This would particularly be handy if the user has a slow internet connection. Here's a quick mock-up:

contribs_txt_progress_bar

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 30, 2015

Member

@joelmoniz this would be on your plate, would you like me to incorporate #3161 in the meantime?

Member

benfry commented Mar 30, 2015

@joelmoniz this would be on your plate, would you like me to incorporate #3161 in the meantime?

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Mar 30, 2015

Member

Yes please. I was actually considering marking this as resolved if #3161 was merged, since I thought it might actually looked neater than the progress bar I had proposed. Could you please let me know if the bar proposed here looks better than the status text, as in #3161? If so, I'd love to add in a bar once #3161 is merged.

Member

joelmoniz commented Mar 30, 2015

Yes please. I was actually considering marking this as resolved if #3161 was merged, since I thought it might actually looked neater than the progress bar I had proposed. Could you please let me know if the bar proposed here looks better than the status text, as in #3161? If so, I'd love to add in a bar once #3161 is merged.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Mar 30, 2015

Member

A bar is better in the long-run, but a lower priority with at least the text version in there.

Member

benfry commented Mar 30, 2015

A bar is better in the long-run, but a lower priority with at least the text version in there.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Mar 30, 2015

Member

Ah perfect. I shall leave this issue open, and shall work on its implementation. Thanks.

Member

joelmoniz commented Mar 30, 2015

Ah perfect. I shall leave this issue open, and shall work on its implementation. Thanks.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 1, 2015

Member

Incorporated for 3.0a10 with #3319

Member

benfry commented Jun 1, 2015

Incorporated for 3.0a10 with #3319

@benfry benfry closed this Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment