Fix placement and visual design when showing error on hover #3173

Closed
shiffman opened this Issue Apr 4, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@shiffman
Member

shiffman commented Apr 4, 2015

Related to #3119:

I like the idea of error info popping up on hover, but two comments:

  1. Placement feels a bit awkward.
  2. Visual design could use some work to be more consistent with overall PDE. In particular the yellow color and padding feels off.

screen shot 2015-04-04 at 10 59 45 am

@benfry benfry changed the title from Error Hover to Fix placement and visual design when showing error on hover Apr 4, 2015

@benfry benfry self-assigned this Apr 4, 2015

@benfry benfry added this to the 3.0 final milestone Sep 11, 2015

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 22, 2015

Contributor

Here is the hover I proposed a while back but I remember there being issue with the triangle in the top left. Let me know if we need to go without it.
pde-sketch-r14-002

Contributor

jamesjgrady commented Sep 22, 2015

Here is the hover I proposed a while back but I remember there being issue with the triangle in the top left. Let me know if we need to go without it.
pde-sketch-r14-002

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 23, 2015

Contributor

After working on the hover for #3407 I'm also questioning the need for this hover box. I think by clicking or hovering on the red dotted line and having the error console highlight the issue would be a better solution.
pde-sketch-r15-error-hover

Contributor

jamesjgrady commented Sep 23, 2015

After working on the hover for #3407 I'm also questioning the need for this hover box. I think by clicking or hovering on the red dotted line and having the error console highlight the issue would be a better solution.
pde-sketch-r15-error-hover

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Sep 24, 2015

Member

I agree that the hover is not necessary and possibly just adding noise.

Member

shiffman commented Sep 24, 2015

I agree that the hover is not necessary and possibly just adding noise.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 24, 2015

Member

So this should probably change to having the correct line highlight in the error listing, and perhaps replacing the text in the big red bar as well?

Member

benfry commented Sep 24, 2015

So this should probably change to having the correct line highlight in the error listing, and perhaps replacing the text in the big red bar as well?

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 24, 2015

Contributor

Yes, this would be the same as the other error screen. See screen grab. No hover necessary.

pde-sketch-r16-error-002

Contributor

jamesjgrady commented Sep 24, 2015

Yes, this would be the same as the other error screen. See screen grab. No hover necessary.

pde-sketch-r16-error-002

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 29, 2015

Member

Actually we can't make it highlight the list item on over, because separately, highlighting a list item will select the line with the error (while promoting it to the console), which makes for a weird chasing-its-tail interaction.

Member

benfry commented Sep 29, 2015

Actually we can't make it highlight the list item on over, because separately, highlighting a list item will select the line with the error (while promoting it to the console), which makes for a weird chasing-its-tail interaction.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 30, 2015

Member

Final implementation is a less hideous tooltip that matches the style of the list in the "Errors" tab at the bottom.

Member

benfry commented Sep 30, 2015

Final implementation is a less hideous tooltip that matches the style of the list in the "Errors" tab at the bottom.

@benfry benfry closed this Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment