New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window size not passing into Tweak Mode in 0233 #3208

Closed
REAS opened this Issue Apr 23, 2015 · 11 comments

Comments

Projects
None yet
5 participants
@REAS
Member

REAS commented Apr 23, 2015

The Display Window is showing up at 100 x 100 pixels when running in Tweak mode, regardless of the dimensions set in size()

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 24, 2015

Member

I suspect that Tweak is doing its own parsing of the size() command and not doing it properly. Went looking for it but didn't find anything immediately.

Member

benfry commented Apr 24, 2015

I suspect that Tweak is doing its own parsing of the size() command and not doing it properly. Went looking for it but didn't find anything immediately.

@benfry benfry added the help wanted label Apr 24, 2015

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Apr 24, 2015

Member

@galsasson any ideas?

Member

shiffman commented Apr 24, 2015

@galsasson any ideas?

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Apr 24, 2015

Contributor

Hi, can you please describe the issue again?
I'm not sure I understand.

Contributor

galsasson commented Apr 24, 2015

Hi, can you please describe the issue again?
I'm not sure I understand.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Apr 25, 2015

Member

When you start a sketch with Tweak, it's not actually the mode anymore as mentioned above, the dimensions from size() aren't passed through and the window shows up as 100 x 100 pixels. This feature is there in the current source and will be in 3.0a6.

Member

REAS commented Apr 25, 2015

When you start a sketch with Tweak, it's not actually the mode anymore as mentioned above, the dimensions from size() aren't passed through and the window shows up as 100 x 100 pixels. This feature is there in the current source and will be in 3.0a6.

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Apr 26, 2015

Contributor

thanks, I will take a look.

Contributor

galsasson commented Apr 26, 2015

thanks, I will take a look.

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Apr 27, 2015

Contributor

Yes, this looks like the same issue, I could reproduce it only when passing a third argument to size.
TweakMode adds two function calls to the beginning of setup (before any user code), so it might be the case.
Also, tweak treats width and height as tweak-able values (and as a result the modified sketch is actually using variables to provide these numbers) and reading the 'size' function reference now it says that numbers should be passed to this function and not variables.
@benfry, Is this a real?

Is there currently a hook to execute code before setup?
If not, I will need to add some code so that tweak will ignore the numbers in setup (which don't really make sense to tweak anyway), then I can move these two functions to the end of setup.

Contributor

galsasson commented Apr 27, 2015

Yes, this looks like the same issue, I could reproduce it only when passing a third argument to size.
TweakMode adds two function calls to the beginning of setup (before any user code), so it might be the case.
Also, tweak treats width and height as tweak-able values (and as a result the modified sketch is actually using variables to provide these numbers) and reading the 'size' function reference now it says that numbers should be passed to this function and not variables.
@benfry, Is this a real?

Is there currently a hook to execute code before setup?
If not, I will need to add some code so that tweak will ignore the numbers in setup (which don't really make sense to tweak anyway), then I can move these two functions to the end of setup.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 27, 2015

Member

The reference has always said that size() goes first and that you shouldn't use variables. It's more strict in 3.0a6 due to changes we need to make in order to get better performance.

Member

benfry commented Apr 27, 2015

The reference has always said that size() goes first and that you shouldn't use variables. It's more strict in 3.0a6 due to changes we need to make in order to get better performance.

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Apr 28, 2015

Contributor

I created a pull request for this issue (#3227) with some additional improvements.

Contributor

galsasson commented Apr 28, 2015

I created a pull request for this issue (#3227) with some additional improvements.

benfry added a commit that referenced this issue Apr 28, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 28, 2015

Member

Incorporated for 3.0a8.

Member

benfry commented Apr 28, 2015

Incorporated for 3.0a8.

@benfry benfry closed this Apr 28, 2015

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Apr 28, 2015

Member

Wonderful. I confirm it's working.

Member

REAS commented Apr 28, 2015

Wonderful. I confirm it's working.

@eric-souther

This comment has been minimized.

Show comment
Hide comment
@eric-souther

eric-souther Jul 1, 2015

Looks like this was fixed in 3.0a8., however no matter what I change with size or fullScreen now when I run tweak mode in 3.0a10 on OS X 10.10.3 I get this error "IllegalStateException: fullScreen() cannot be used here, see https://processing.org/reference/fullScreen_.html" All I have in setup is fullScreen(P3D), and in draw a background and ellipse.

eric-souther commented Jul 1, 2015

Looks like this was fixed in 3.0a8., however no matter what I change with size or fullScreen now when I run tweak mode in 3.0a10 on OS X 10.10.3 I get this error "IllegalStateException: fullScreen() cannot be used here, see https://processing.org/reference/fullScreen_.html" All I have in setup is fullScreen(P3D), and in draw a background and ellipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment