New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace processing.mode.java.tweak.ColorSelector with processing.app.ColorChooser #3209

Closed
benfry opened this Issue Apr 24, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@benfry
Member

benfry commented Apr 24, 2015

Some subclassing may still be required, but let's not have a near duplicate in the source (with the tweak mode version now behind what's in processing.app.ColorChooser).

@benfry benfry added the help wanted label Apr 24, 2015

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson Apr 27, 2015

Contributor

Also, TweakMode color selector is now broken since 1b9e12e
It fails in the function getMaximumSize.
frame.isResizable() returns true, even when I set my frame resizable to false. then it fails on super.getMaximumSize.
I tried messing around with it a bit but couldn't find the source.

Contributor

galsasson commented Apr 27, 2015

Also, TweakMode color selector is now broken since 1b9e12e
It fails in the function getMaximumSize.
frame.isResizable() returns true, even when I set my frame resizable to false. then it fails on super.getMaximumSize.
I tried messing around with it a bit but couldn't find the source.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 1, 2015

Member

@federicobond Wanna give me a hand here? Either applying the same changes as #2975, or better yet, a subclass that extends the original selector with only the necessary overrides?

Member

benfry commented May 1, 2015

@federicobond Wanna give me a hand here? Either applying the same changes as #2975, or better yet, a subclass that extends the original selector with only the necessary overrides?

@federicobond

This comment has been minimized.

Show comment
Hide comment
@federicobond

federicobond May 1, 2015

Contributor

@benfry sure! I'll see what I can do. I managed to build a working tweak color selector from 1b9e12e's parent commit and some custom code fixes to see how it worked.

Contributor

federicobond commented May 1, 2015

@benfry sure! I'll see what I can do. I managed to build a working tweak color selector from 1b9e12e's parent commit and some custom code fixes to see how it worked.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 1, 2015

Member

Awesome, thank you. Not looking for heavy reworking or refactoring (we have bigger issues to deal with), just a simple update based on the work you already did. Thanks!

Member

benfry commented May 1, 2015

Awesome, thank you. Not looking for heavy reworking or refactoring (we have bigger issues to deal with), just a simple update based on the work you already did. Thanks!

@galsasson

This comment has been minimized.

Show comment
Hide comment
@galsasson

galsasson May 3, 2015

Contributor

Thank you very much for the effort, @federicobond and @benfry! Let me know if I you need any help.

Contributor

galsasson commented May 3, 2015

Thank you very much for the effort, @federicobond and @benfry! Let me know if I you need any help.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 11, 2015

Member

Nevermind, now fixed. Had to get the build working again.

Member

benfry commented May 11, 2015

Nevermind, now fixed. Had to get the build working again.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman May 11, 2015

Member

ah, ok, was wondering why my build wasn't working, thought it was me.

Member

shiffman commented May 11, 2015

ah, ok, was wondering why my build wasn't working, thought it was me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment