New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences window elements not sized correctly in 3.0a6 #3212

Closed
benfry opened this Issue Apr 25, 2015 · 15 comments

Comments

Projects
None yet
2 participants
@benfry
Member

benfry commented Apr 25, 2015

Regressions introduced by #3191

preferences-cropped

On OS X, the window contents are not sized correctly.

In addition, the "Editor font size" menu is enormous and runs the width of the window.

@benfry benfry added the help wanted label Apr 25, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 25, 2015

Member

Fixed the bounds, but we're still definitely in the "ugly Java UI" category, which is why I didn't use a layout manager in the code in the first place.

prefs-mac

This should be a straightforward project to fix up, please help!

Member

benfry commented Apr 25, 2015

Fixed the bounds, but we're still definitely in the "ugly Java UI" category, which is why I didn't use a layout manager in the code in the first place.

prefs-mac

This should be a straightforward project to fix up, please help!

@benfry benfry changed the title from Preferences window not sized correctly to Preferences window elements not sized correctly in 3.0a6 Apr 25, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 25, 2015

Member

And for reference, this is what it looked like before the PR:

screen shot 2015-04-25 at 12 52 51 pm

Looks like we also lost the "MB" designation after the memory text field.

Member

benfry commented Apr 25, 2015

And for reference, this is what it looked like before the PR:

screen shot 2015-04-25 at 12 52 51 pm

Looks like we also lost the "MB" designation after the memory text field.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 25, 2015

Member

Hm, on further consideration, I wonder if it's time to have separate tabs for modes. Because of the PDE X integration, half of those items are specific to Java Mode.

Member

benfry commented Apr 25, 2015

Hm, on further consideration, I wonder if it's time to have separate tabs for modes. Because of the PDE X integration, half of those items are specific to Java Mode.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 26, 2015

Member

Sorry, i was busy with some college project for my exams.
This is not a issue that is happening on Ubuntu all the time, some time it does and some time the size is ok ( that's why it passed through my testing ). I will try to fix this today.

Member

Akarshit commented Apr 26, 2015

Sorry, i was busy with some college project for my exams.
This is not a issue that is happening on Ubuntu all the time, some time it does and some time the size is ok ( that's why it passed through my testing ). I will try to fix this today.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 26, 2015

Member

Thanks for looking into this. I've merged the changes but it looks like we still have some issues w/ the font drop-downs:

font-boxes

Let's just do setResizable(false) as well... Resizing the window doesn't do much for us.

Member

benfry commented Apr 26, 2015

Thanks for looking into this. I've merged the changes but it looks like we still have some issues w/ the font drop-downs:

font-boxes

Let's just do setResizable(false) as well... Resizing the window doesn't do much for us.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 26, 2015

Member

I will hard-code these values for now.

Member

Akarshit commented Apr 26, 2015

I will hard-code these values for now.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 26, 2015

Member

They can't just use their default width and have extra empty space to their right (ala BoxLayout or FlowLayout)?

Member

benfry commented Apr 26, 2015

They can't just use their default width and have extra empty space to their right (ala BoxLayout or FlowLayout)?

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 26, 2015

Member

Actually they are working fine on Ubuntu, but i will try to do something to make them compatible with Mac. The main problem is i don't have access to a Mac to test.

Member

Akarshit commented Apr 26, 2015

Actually they are working fine on Ubuntu, but i will try to do something to make them compatible with Mac. The main problem is i don't have access to a Mac to test.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 26, 2015

Member

Hm, wonder if we should switch to BoxLayout. Much simpler (to maintain as well), and it's not like we're not doing anything special. We had problems with MovieMaker and GroupLayout for a long time. Find/Replace seems to be working well, though.

Member

benfry commented Apr 26, 2015

Hm, wonder if we should switch to BoxLayout. Much simpler (to maintain as well), and it's not like we're not doing anything special. We had problems with MovieMaker and GroupLayout for a long time. Find/Replace seems to be working well, though.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 26, 2015

Member

I think it would a very simple fix if someone with Mac can play with it. I think only the parameters passed in https://github.com/processing/processing/blob/master/app/src/processing/app/PreferencesFrame.java#L602 and line 604 needs to be changed.

Member

Akarshit commented Apr 26, 2015

I think it would a very simple fix if someone with Mac can play with it. I think only the parameters passed in https://github.com/processing/processing/blob/master/app/src/processing/app/PreferencesFrame.java#L602 and line 604 needs to be changed.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 26, 2015

Member

I'm looking through it on OS X but not familiar enough with GroupLayout to make it work. From this it looks like the top-to-bottom list of items shouldn't be using a parallel group, because it'll force them all to the maximum width of the window.

Member

benfry commented Apr 26, 2015

I'm looking through it on OS X but not familiar enough with GroupLayout to make it work. From this it looks like the top-to-bottom list of items shouldn't be using a parallel group, because it'll force them all to the maximum width of the window.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 26, 2015

Member

I dont think that this is the problem, the problem is that the dropdown fields are taking way too much space by default ( on Mac ) and this is defining the width of the Pref Window

Member

Akarshit commented Apr 26, 2015

I dont think that this is the problem, the problem is that the dropdown fields are taking way too much space by default ( on Mac ) and this is defining the width of the Pref Window

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 26, 2015

Member

Well, one works... (with #3220)

screen shot 2015-04-26 at 5 42 21 pm

Member

benfry commented Apr 26, 2015

Well, one works... (with #3220)

screen shot 2015-04-26 at 5 42 21 pm

@benfry benfry closed this in dc27365 Apr 27, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Apr 27, 2015

Member

Layout fixed for 3.0a7.

Member

benfry commented Apr 27, 2015

Layout fixed for 3.0a7.

@benfry benfry removed the help wanted label Apr 27, 2015

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Apr 27, 2015

Member

Oh nice!
I will add the documentation for the complete code of Preference Window and would clean up old commented code as the implementation has changes totally.

Member

Akarshit commented Apr 27, 2015

Oh nice!
I will add the documentation for the complete code of Preference Window and would clean up old commented code as the implementation has changes totally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment