New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd-click behavior on function/variable is firing when cmd-click not pressed #3242

Closed
shiffman opened this Issue May 6, 2015 · 10 comments

Comments

Projects
None yet
3 participants
@shiffman
Member

shiffman commented May 6, 2015

I'm experiencing some strange behavior in the PDE. I've noticed that "command-clicking" a function or variable name jumps you directly to the function definition or variable declaration in the PDE. This is a useful feature.

This may be my own personal faulty keyboarding, but I am experiencing this jump a lot at unwanted times. I use command-c and command-v quite often to copy/paste variable and function names. I'm noticing that the jump is triggering from time to time and my copy/paste goes all crazy.

The answer may be for me to refine my behavior, but I'd thought I'd share / post in case anyone else experiences this. @Manindra29 perhaps you could look at this with @joelmoniz during GSoC in case there's a small timing adjustment that can be made.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman May 6, 2015

Member

I should add I'm on a Mac using 10.10 and 3.0a7.

Member

shiffman commented May 6, 2015

I should add I'm on a Mac using 10.10 and 3.0a7.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 6, 2015

Member

Hm, that sounds like the mouse listener that handles jumping to declarations isn't set up properly and it may be firing at the wrong time (or isn't being prevented when it's a mouse/key event on something else).

Member

benfry commented May 6, 2015

Hm, that sounds like the mouse listener that handles jumping to declarations isn't set up properly and it may be firing at the wrong time (or isn't being prevented when it's a mouse/key event on something else).

@benfry benfry changed the title from Command click --> jump to declaration problem to Cmd-click behavior on function/variable is firing when cmd-click not pressed May 6, 2015

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman May 6, 2015

Member

Also, related to this problem I've discovered on a mac that cntrl-click also jumps to a function declaration. This is problematic when using cntrl-click as a right-click on Mac. For example:

error

Member

shiffman commented May 6, 2015

Also, related to this problem I've discovered on a mac that cntrl-click also jumps to a function declaration. This is problematic when using cntrl-click as a right-click on Mac. For example:

error

@Manindra29

This comment has been minimized.

Show comment
Hide comment
@Manindra29

Manindra29 May 6, 2015

Member

The jump to declaration is currently set to trigger when cmd or ctrl key is
pressed during mouse click. It should be changed to Cmd only for Mac. This
should be an easy fix. Will add it to my list.

On Wed, May 6, 2015 at 1:05 PM, Daniel Shiffman notifications@github.com
wrote:

Also, related to this problem I've discovered on a mac that cntrl-click
also jumps to a function declaration. This is problematic when using
cntrl-click as a right-click on Mac. For example:

[image: error]
https://cloud.githubusercontent.com/assets/191758/7502378/936aa56c-f433-11e4-9f05-d6dc3afd13a3.png


Reply to this email directly or view it on GitHub
#3242 (comment)
.

Member

Manindra29 commented May 6, 2015

The jump to declaration is currently set to trigger when cmd or ctrl key is
pressed during mouse click. It should be changed to Cmd only for Mac. This
should be an easy fix. Will add it to my list.

On Wed, May 6, 2015 at 1:05 PM, Daniel Shiffman notifications@github.com
wrote:

Also, related to this problem I've discovered on a mac that cntrl-click
also jumps to a function declaration. This is problematic when using
cntrl-click as a right-click on Mac. For example:

[image: error]
https://cloud.githubusercontent.com/assets/191758/7502378/936aa56c-f433-11e4-9f05-d6dc3afd13a3.png


Reply to this email directly or view it on GitHub
#3242 (comment)
.

@Manindra29

This comment has been minimized.

Show comment
Hide comment
@Manindra29

Manindra29 May 6, 2015

Member

That's a little odd. I'll take a look into the listener again.

On Wed, May 6, 2015 at 11:26 AM, Ben Fry notifications@github.com wrote:

Hm, that sounds like the mouse listener that handles jumping to
declarations isn't set up properly and it may be firing at the wrong time
(or isn't being prevented when it's a mouse/key event on something else).


Reply to this email directly or view it on GitHub
#3242 (comment)
.

Member

Manindra29 commented May 6, 2015

That's a little odd. I'll take a look into the listener again.

On Wed, May 6, 2015 at 11:26 AM, Ben Fry notifications@github.com wrote:

Hm, that sounds like the mouse listener that handles jumping to
declarations isn't set up properly and it may be firing at the wrong time
(or isn't being prevented when it's a mouse/key event on something else).


Reply to this email directly or view it on GitHub
#3242 (comment)
.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 16, 2015

Member

I suspect this might be related to the cleanups I tried to do that are probably also causing #3286. The whole setup for how listeners were piggybacking on each other to do the debugger (and then another set again for tweak mode!) was really problematic. We need to sort that out.

Member

benfry commented May 16, 2015

I suspect this might be related to the cleanups I tried to do that are probably also causing #3286. The whole setup for how listeners were piggybacking on each other to do the debugger (and then another set again for tweak mode!) was really problematic. We need to sort that out.

Manindra29 added a commit that referenced this issue May 16, 2015

@Manindra29

This comment has been minimized.

Show comment
Hide comment
@Manindra29

Manindra29 May 16, 2015

Member

I've disabled Ctrl-Click jump to definition on Mac. It will only fire when Cmd is pressed on Mac. One way I can think of Cmd-C triggering jump to definition is if you may be accidentally touching your trackpad..? Because jump to definition is a mouse event only. If you are purely pressing keys, it shouldn't trigger ideally.

Member

Manindra29 commented May 16, 2015

I've disabled Ctrl-Click jump to definition on Mac. It will only fire when Cmd is pressed on Mac. One way I can think of Cmd-C triggering jump to definition is if you may be accidentally touching your trackpad..? Because jump to definition is a mouse event only. If you are purely pressing keys, it shouldn't trigger ideally.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 16, 2015

Member

Hm, I wonder if right clicks are firing cmd-click on OS X (the reverse is true...)

Member

benfry commented May 16, 2015

Hm, I wonder if right clicks are firing cmd-click on OS X (the reverse is true...)

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 16, 2015

Member

@shiffman Can you confirm this is working, and if so, we'll close?

Member

benfry commented May 16, 2015

@shiffman Can you confirm this is working, and if so, we'll close?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 19, 2015

Member

Looks like it's working in 3.0a8.

Member

benfry commented May 19, 2015

Looks like it's working in 3.0a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment