New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find and Replace" button should be labelled "Replace and Find" #3247

Closed
teo1978 opened this Issue May 7, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@teo1978

teo1978 commented May 7, 2015

The "Find and Replace" button in the Find window has a misleading label, because it indeeds replaces and finds, rather than find and replace. Its behavior is fine, it's just the label that is misleading.

If the Find window is going to be kept as unconventional as it is, it is important that the buttons are named properly, because it's already counterintuitive enough.

Note BTW that many editors have separate "Find" and "Find and Replace" windows, and in my opinion that's better. It's a bit "scary" when you just want to search and you see a Find&Replace window. You get the impression that you may too easily do a replace by mistake, even if that is not the case. For a long time I was too scared to type the keyword and press Enter, fearing that this would replace it with "", so I always clicked on the Find button just in case. Then I found out that precaution was not necessary, as Enter by default does a Find (which is the most reasonable behavior).

benfry added a commit that referenced this issue May 12, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 12, 2015

Member

It was a typo introduced when that code was internationalized. It's now fixed.

Member

benfry commented May 12, 2015

It was a typo introduced when that code was internationalized. It's now fixed.

@benfry benfry closed this May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment