New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for incorrect function arguments is wonky #3268

Closed
shiffman opened this Issue May 11, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@shiffman
Member

shiffman commented May 11, 2015

In 3.0a7:

size(200,200);
ellipse(100,70,60); 

Error:

The "ellipse" "ellipse"def expects parameters like this . . . 

Should say:

The function "ellipse" expects parameters like this . . . 

Not sure if this is related to already fixed #3225. (Not able to get current build to work, apologies for not being able to test there.)

screenshot 2015-05-11 16 41 56

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 11, 2015

Member

I probably goofed something with the replacements while trying to minimize some of that code. Should be an easy fix.

Member

benfry commented May 11, 2015

I probably goofed something with the replacements while trying to minimize some of that code. Should be an easy fix.

@benfry benfry closed this in 7a4a4be May 11, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 11, 2015

Member

Fixed for 3.0a8. Had to do quite a bit of work on the simplifier, so please re-check any of those that may have broken in the process. It's also possible to edit more of that text directly inside PDE.properties. Before it was using its own substitution method.

Member

benfry commented May 11, 2015

Fixed for 3.0a8. Had to do quite a bit of work on the simplifier, so please re-check any of those that may have broken in the process. It's also possible to edit more of that text directly inside PDE.properties. Before it was using its own substitution method.

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman May 12, 2015

Member

This fixed but it broke "the function ___ does not exist", i.e.

size(200, 200);
elipse(100,70,60,50); 
The function %s does not exist

screenshot 2015-05-12 09 08 29

Member

shiffman commented May 12, 2015

This fixed but it broke "the function ___ does not exist", i.e.

size(200, 200);
elipse(100,70,60,50); 
The function %s does not exist

screenshot 2015-05-12 09 08 29

@shiffman shiffman reopened this May 12, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 12, 2015

Member

Ok, checked in the fix for that. Go ahead and close this if it's working for you.

Member

benfry commented May 12, 2015

Ok, checked in the fix for that. Go ahead and close this if it's working for you.

benfry added a commit that referenced this issue May 12, 2015

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman May 12, 2015

Member

I can confirm that both of these errors work properly.

Member

shiffman commented May 12, 2015

I can confirm that both of these errors work properly.

@shiffman shiffman closed this May 12, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 12, 2015

Member

Phew; progress!

Member

benfry commented May 12, 2015

Phew; progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment