New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider highlighting breakpoints more #3307

Closed
shiffman opened this Issue May 20, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@shiffman
Member

shiffman commented May 20, 2015

From #3093: "I would also personally like to see lines with breakpoints highlighted a bit more strongly (the <> feels quite subtle to me) but this is a more minor point and I defer to the wisdom of others with better design instincts."

Feel free to close if you disagree.

@shiffman shiffman added the debugger label May 20, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 20, 2015

Member

I agree. I think James may even have them more prominent in the comp, but we'll make it happen in either case.

Maybe an actual diamond shape instead of <> might help too.

Member

benfry commented May 20, 2015

I agree. I think James may even have them more prominent in the comp, but we'll make it happen in either case.

Maybe an actual diamond shape instead of <> might help too.

@benfry benfry added this to the 3.0 final milestone Jun 16, 2015

@benfry benfry self-assigned this Sep 9, 2015

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 23, 2015

Contributor

I like the diamond - there is a diamond glyph in Source Code Pro, but it will need to be resized and the baseline and position shifted. Let me know if you have questions.

pde-sketch-r16-breakpoint

Contributor

jamesjgrady commented Sep 23, 2015

I like the diamond - there is a diamond glyph in Source Code Pro, but it will need to be resized and the baseline and position shifted. Let me know if you have questions.

pde-sketch-r16-breakpoint

@shiffman

This comment has been minimized.

Show comment
Hide comment
@shiffman

shiffman Sep 24, 2015

Member

This looks great, thank you!

Member

shiffman commented Sep 24, 2015

This looks great, thank you!

@benfry benfry closed this in 2361ce0 Sep 24, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 24, 2015

Member

All set; along with the step arrow being a right-facing arrow instead of ->
screen shot 2015-09-24 at 5 50 31 am

Member

benfry commented Sep 24, 2015

All set; along with the step arrow being a right-facing arrow instead of ->
screen shot 2015-09-24 at 5 50 31 am

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Sep 24, 2015

Member

Wonderful.

Member

REAS commented Sep 24, 2015

Wonderful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment