New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribs listed multiple times (because they're listed multiple times in contribs.txt) #3353

Closed
benfry opened this Issue Jun 4, 2015 · 14 comments

Comments

Projects
None yet
6 participants
@benfry
Member

benfry commented Jun 4, 2015

Help me @prisonerjohn, you're my only hope.

@benfry benfry added the manager label Jun 4, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 4, 2015

Member

Quickly filing this per discussion; something for @Akarshit and @prisonerjohn to sort out.

Member

benfry commented Jun 4, 2015

Quickly filing this per discussion; something for @Akarshit and @prisonerjohn to sort out.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jun 15, 2015

Member

Some more information on this:

In the current setup, if a contribution is listed in more than one category, it is duplicated in the contribs.txt file with two different ID numbers. See an example of this here and here. This is bad for many reasons (hard to maintain, duplicated entries, etc.) so maybe now is a good time to fix it.

I propose formatting entries in contribs.txt with a comma-separated list of categories. For example:

library
category=Geometry,Typography
minRevision=0
authorList=[Ricard Marxer](http://www.ricardmarxer.com/)
name=Geomerative
maxRevision=0
sentence=Extends 2D geometry operations to facilitate generative geometry. Includes a TrueType font interpreter.
url=http://www.ricardmarxer.com/geomerative
prettyVersion=
paragraph=This library exposes the shapes (such as vector drawings or typographies) in a more approchable way. Geomerative makes it easy to access the paths, the handles and the points, making it easy to develop generative typography and geometry pieces in Processing.
version=40
download=http://www.ricardmarxer.com/geomerative/geomerative.zip
id=038

Is this something you would be able to work with in the PDE to assign a single contribution entry to many categories?

Member

prisonerjohn commented Jun 15, 2015

Some more information on this:

In the current setup, if a contribution is listed in more than one category, it is duplicated in the contribs.txt file with two different ID numbers. See an example of this here and here. This is bad for many reasons (hard to maintain, duplicated entries, etc.) so maybe now is a good time to fix it.

I propose formatting entries in contribs.txt with a comma-separated list of categories. For example:

library
category=Geometry,Typography
minRevision=0
authorList=[Ricard Marxer](http://www.ricardmarxer.com/)
name=Geomerative
maxRevision=0
sentence=Extends 2D geometry operations to facilitate generative geometry. Includes a TrueType font interpreter.
url=http://www.ricardmarxer.com/geomerative
prettyVersion=
paragraph=This library exposes the shapes (such as vector drawings or typographies) in a more approchable way. Geomerative makes it easy to access the paths, the handles and the points, making it easy to develop generative typography and geometry pieces in Processing.
version=40
download=http://www.ricardmarxer.com/geomerative/geomerative.zip
id=038

Is this something you would be able to work with in the PDE to assign a single contribution entry to many categories?

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jun 15, 2015

Member

This idea sounds great to me. @Akarshit is this something you could help us implement while you are working on the CM?

Member

alignedleft commented Jun 15, 2015

This idea sounds great to me. @Akarshit is this something you could help us implement while you are working on the CM?

@benfry benfry added this to the 3.0 final milestone Jun 16, 2015

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Jun 19, 2015

Member

I think this might already be supported by the CM, since when it parses the category field, it splits it up based on commas, and returns a List of Strings of valid categories?

Member

joelmoniz commented Jun 19, 2015

I think this might already be supported by the CM, since when it parses the category field, it splits it up based on commas, and returns a List of Strings of valid categories?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jun 22, 2015

Member

Ok, that's great! I'll make the changes on my end and report back.

Member

prisonerjohn commented Jun 22, 2015

Ok, that's great! I'll make the changes on my end and report back.

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jun 26, 2015

Member

I made the changes to the build_listings script (and updated the field names). An entry now looks something like this:

library
minRevision=0
name=Hermes
maxRevision=0
sentence=Experimental game framework and engine for rapid prototyping of games and simulations.
url=http://rdlester.github.com/hermes
prettyVersion=2.0
paragraph=Leverges the strengths of Object-Oriented Design and the ease of Processing to make it easy to bring game mechanics to life. Built-in OSC support makes it easy to enable communication between your games and external data sources. Also includes animation/sprite and physics libraries that can be used outside the framework.
version=5
authors=Ryan Lester, Chris Novello, Sam Eilertsen, and Jen Kovnats
download=http://rdlester.github.com/hermes/downloads/hermes.zip
id=083
categories=Geometry,Compilation,Simulation,Animation

I'm not sure what I need to do to get this updated list at http://processing.org/contrib_generate/contribs.txt, paging @REAS @alignedleft

Member

prisonerjohn commented Jun 26, 2015

I made the changes to the build_listings script (and updated the field names). An entry now looks something like this:

library
minRevision=0
name=Hermes
maxRevision=0
sentence=Experimental game framework and engine for rapid prototyping of games and simulations.
url=http://rdlester.github.com/hermes
prettyVersion=2.0
paragraph=Leverges the strengths of Object-Oriented Design and the ease of Processing to make it easy to bring game mechanics to life. Built-in OSC support makes it easy to enable communication between your games and external data sources. Also includes animation/sprite and physics libraries that can be used outside the framework.
version=5
authors=Ryan Lester, Chris Novello, Sam Eilertsen, and Jen Kovnats
download=http://rdlester.github.com/hermes/downloads/hermes.zip
id=083
categories=Geometry,Compilation,Simulation,Animation

I'm not sure what I need to do to get this updated list at http://processing.org/contrib_generate/contribs.txt, paging @REAS @alignedleft

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Jun 26, 2015

Member

There's a "Pull Latest Changes" in Generate, that updates the entire site from GitHub.

Member

REAS commented Jun 26, 2015

There's a "Pull Latest Changes" in Generate, that updates the entire site from GitHub.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jun 26, 2015

Member

@prisonerjohn Let me know if you want me to update this on the main site (or just beta).

Member

alignedleft commented Jun 26, 2015

@prisonerjohn Let me know if you want me to update this on the main site (or just beta).

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jul 1, 2015

Member

OK, this is ready on my end.
I built and ran Processing locally and used http://beta.processing.org/contrib_generate/contribs.txt to get the list, it seems to be working fine.

Member

prisonerjohn commented Jul 1, 2015

OK, this is ready on my end.
I built and ran Processing locally and used http://beta.processing.org/contrib_generate/contribs.txt to get the list, it seems to be working fine.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jul 2, 2015

Member

@prisonerjohn should we close this issue then? Do you want/need me to regenerate contribs.txt on the live site?

Member

alignedleft commented Jul 2, 2015

@prisonerjohn should we close this issue then? Do you want/need me to regenerate contribs.txt on the live site?

@prisonerjohn

This comment has been minimized.

Show comment
Hide comment
@prisonerjohn

prisonerjohn Jul 2, 2015

Member

Yes and yes, unless someone wants to have a second look first.

Member

prisonerjohn commented Jul 2, 2015

Yes and yes, unless someone wants to have a second look first.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jul 2, 2015

Member

At a glance, this looks OK to me. @Akarshit could you double-check this fix? (I think just click the URL above and scan for duplicates.)

Once we have another set of eyes on it, I can update the live site and close this issue. Thanks!

Member

alignedleft commented Jul 2, 2015

At a glance, this looks OK to me. @Akarshit could you double-check this fix? (I think just click the URL above and scan for duplicates.)

Once we have another set of eyes on it, I can update the live site and close this issue. Thanks!

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Jul 2, 2015

Member

@alignedleft looks fine to me

Member

Akarshit commented Jul 2, 2015

@alignedleft looks fine to me

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jul 18, 2015

Member

Thanks, @Akarshit and @prisonerjohn.

I've updated the live site and tested 2.2.1 and the current 3.0a build, and it looks OK to me. If you see any problems, please log a new issue.

Member

alignedleft commented Jul 18, 2015

Thanks, @Akarshit and @prisonerjohn.

I've updated the live site and tested 2.2.1 and the current 3.0a build, and it looks OK to me. If you see any problems, please log a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment