New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visually distinguish warnings from errors in the console #3406

Closed
shiffman opened this Issue Jun 19, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@shiffman
Member

shiffman commented Jun 19, 2015

Note the following code:

void setup() {
  int myVar = 10;
}

void draw() {
  ellipse(myVar, 10, 10, 10);
}

Produces one warning and one error. These are distinguished in the editor with a yellow squiggly line and a red one. However, in the console they appear equally as errors (though the tab is not colored red if only the warning is there.) I see we have a preference to "show warnings" but should they also be visually distinctive if shown?

@benfry benfry changed the title from Should we distinguish warnings in the error console? to visually distinguish warnings from errors in the console Jun 19, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jun 19, 2015

Member

Yes, we should. I'll add it to the list.

Member

benfry commented Jun 19, 2015

Yes, we should. I'll add it to the list.

@benfry benfry self-assigned this Jun 19, 2015

@benfry benfry added this to the 3.0 final milestone Jun 19, 2015

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 23, 2015

Contributor

Here are two screen shots outlining the warning vs. the error UI.

Let me know if this is clear or you have questions on the interaction.

pde-sketch-r16-warning

pde-sketch-r16-error

Contributor

jamesjgrady commented Sep 23, 2015

Here are two screen shots outlining the warning vs. the error UI.

Let me know if this is clear or you have questions on the interaction.

pde-sketch-r16-warning

pde-sketch-r16-error

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 23, 2015

Member

Not sure if we can have different highlight colors, though the idea here is that it needs to be possible to tell error/warning w/o having to click on it.

Member

benfry commented Sep 23, 2015

Not sure if we can have different highlight colors, though the idea here is that it needs to be possible to tell error/warning w/o having to click on it.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 23, 2015

Member

Maybe even just adding a red or orange dot next to the line, and then the highlight color could reinforce it....

Member

benfry commented Sep 23, 2015

Maybe even just adding a red or orange dot next to the line, and then the highlight color could reinforce it....

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 23, 2015

Contributor

I think that could work. Here are revised sketches.

pde-sketch-r16-error-002

pde-sketch-r16-warning-002

Contributor

jamesjgrady commented Sep 23, 2015

I think that could work. Here are revised sketches.

pde-sketch-r16-error-002

pde-sketch-r16-warning-002

@benfry benfry closed this in a89a06e Sep 24, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 24, 2015

Member

All set. Managed to get the selection background color to change as well.

Member

benfry commented Sep 24, 2015

All set. Managed to get the selection background color to change as well.

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Sep 29, 2015

Contributor

One more thought on error vs warning so it's not so visually violating. Seems like the orange warning is a bit overkill. This would also remove any inner glow issues.

pde-sketch-r16-error-003

pde-sketch-r16-warning-003

Contributor

jamesjgrady commented Sep 29, 2015

One more thought on error vs warning so it's not so visually violating. Seems like the orange warning is a bit overkill. This would also remove any inner glow issues.

pde-sketch-r16-error-003

pde-sketch-r16-warning-003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment