New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2x versions of the Contribution Manager icons #3478

Closed
benfry opened this Issue Jul 17, 2015 · 10 comments

Comments

Projects
None yet
5 participants
@benfry
Member

benfry commented Jul 17, 2015

We'll need double-size images for the files in lib/manager. As with other components, these should include -1x and -2x in their names.

In the code, select the necessary size based on Toolkit.highResDisplay(). You can see the implementations in other UI classes such as EditorFooter.java for an example.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry
Member

benfry commented Jul 17, 2015

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Jul 17, 2015

Member

Thanks @benfry for pointing that out. The current icons were extracted by me from the wireframes(and i am really bad at photoshop).

I will implement this in the code.

Member

Akarshit commented Jul 17, 2015

Thanks @benfry for pointing that out. The current icons were extracted by me from the wireframes(and i am really bad at photoshop).

I will implement this in the code.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Jul 18, 2015

Member

If possible, it would be best for @alignedleft or James to do this, they have the excellent design skillzz.

Member

REAS commented Jul 18, 2015

If possible, it would be best for @alignedleft or James to do this, they have the excellent design skillzz.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jul 18, 2015

Member

I will make the icons, but @Akarshit I'll need your help to implement them. I'm working on mockups for the CM now. The icons in the wireframes were just rough concepts.

Member

alignedleft commented Jul 18, 2015

I will make the icons, but @Akarshit I'll need your help to implement them. I'm working on mockups for the CM now. The icons in the wireframes were just rough concepts.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Jul 18, 2015

Member

@REAS Do you know who designed the new console and errors tab icons?

Member

alignedleft commented Jul 18, 2015

@REAS Do you know who designed the new console and errors tab icons?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Jul 18, 2015

Member

Those were done by James.

Member

benfry commented Jul 18, 2015

Those were done by James.

@REAS

This comment has been minimized.

Show comment
Hide comment
@REAS

REAS Jul 18, 2015

Member

@alignedleft I'll send you James' email address over email.

Member

REAS commented Jul 18, 2015

@alignedleft I'll send you James' email address over email.

@benfry benfry added this to the 3.0 final milestone Aug 14, 2015

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Aug 18, 2015

Contributor

@alignedleft @benfry I'm going to send you a .zip file with the icons now.

Contributor

jamesjgrady commented Aug 18, 2015

@alignedleft @benfry I'm going to send you a .zip file with the icons now.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 19, 2015

Member

Icons are now checked in, changing title to refer to implementation.

Member

benfry commented Aug 19, 2015

Icons are now checked in, changing title to refer to implementation.

@benfry benfry changed the title from Need 2x versions of the Contribution Manager icons to Implement 2x versions of the Contribution Manager icons Aug 19, 2015

@benfry benfry assigned benfry and unassigned alignedleft Sep 20, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 20, 2015

Member

Finished for 3.0 beta 7.

Member

benfry commented Sep 20, 2015

Finished for 3.0 beta 7.

@benfry benfry closed this Sep 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment