New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM column widths change with selection #3609

Closed
alignedleft opened this Issue Aug 15, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@alignedleft
Member

alignedleft commented Aug 15, 2015

This is a weird one. Here is the CM panel showing the Android mode selected. Note the column widths.

screen shot 2015-08-14 at 9 47 45 pm

Now, when I select the Python mode in the list (which is disabled and incompatible), the Name column jumps to be much wider, pushing the Author column (and install/update/remove buttons) out to the right.

screen shot 2015-08-14 at 9 47 55 pm

The column widths should not change when the selection changes.

@alignedleft alignedleft added this to the 3.0 final milestone Aug 15, 2015

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 15, 2015

Member

@benfry I am unable to track the exact cause of the issue, but i have found out that this is occurring in libraries whose pretty version contains some text.
These libraries are -

  1. Python - prettyVersion=Build 0412, built 2015/07/08 14:03
  2. Syphon - prettyVersion=1.0-RC3
  3. HE_Mesh 2014 - prettyVersion=2.0.15 „Random”
  4. Android Mode - prettyVersion=3alpha
    I think this is occurring because of somewhere a exception getting thrown when these are tried to convert to a integer form or something like that.
    Do you have any idea regarding this.
Member

Akarshit commented Aug 15, 2015

@benfry I am unable to track the exact cause of the issue, but i have found out that this is occurring in libraries whose pretty version contains some text.
These libraries are -

  1. Python - prettyVersion=Build 0412, built 2015/07/08 14:03
  2. Syphon - prettyVersion=1.0-RC3
  3. HE_Mesh 2014 - prettyVersion=2.0.15 „Random”
  4. Android Mode - prettyVersion=3alpha
    I think this is occurring because of somewhere a exception getting thrown when these are tried to convert to a integer form or something like that.
    Do you have any idea regarding this.
@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 15, 2015

Member

I don't really understand--the point of prettyVersion is that it can contain text. So all of them should.

Member

benfry commented Aug 15, 2015

I don't really understand--the point of prettyVersion is that it can contain text. So all of them should.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 15, 2015

Member

I am sure about this because if i edit the contribs.txt and change Python's prettyVersion to something like 01 the column width doesn't change when selecting Python now.

prettyVersion like 3a, 1.0.1 are working fine

Member

Akarshit commented Aug 15, 2015

I am sure about this because if i edit the contribs.txt and change Python's prettyVersion to something like 01 the column width doesn't change when selecting Python now.

prettyVersion like 3a, 1.0.1 are working fine

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 16, 2015

Member

@benfry i figured out what was wrong. Actually there is a label above the update button which shows text like "Version prettyVersion available/installed". This was set invisible but coded to occupy space still. This was causing the statusPanel to resize.
One of a solution would be to extract the version part from the prettyVersion but to do this all the libraries having different forms of prettyVersion would require a check. I was wondering if this was supposed to be done at server-side ?

Member

Akarshit commented Aug 16, 2015

@benfry i figured out what was wrong. Actually there is a label above the update button which shows text like "Version prettyVersion available/installed". This was set invisible but coded to occupy space still. This was causing the statusPanel to resize.
One of a solution would be to extract the version part from the prettyVersion but to do this all the libraries having different forms of prettyVersion would require a check. I was wondering if this was supposed to be done at server-side ?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 16, 2015

Member

No, don't mess with the contents of prettyVersion. The Python Mode is an issue that should be fixed separately in contribs—that's a whole build string he's using, not a version. But even in fixing that, it sounds like you're looking for ways to paper over something bad in the code. There shouldn't be a reason that columns are resizing when a user clicks different rows in an interface.

Member

benfry commented Aug 16, 2015

No, don't mess with the contents of prettyVersion. The Python Mode is an issue that should be fixed separately in contribs—that's a whole build string he's using, not a version. But even in fixing that, it sounds like you're looking for ways to paper over something bad in the code. There shouldn't be a reason that columns are resizing when a user clicks different rows in an interface.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 16, 2015

Member

I think i was not able to express my self clearly.
When i select a contibution there is text displayed below the install button like below
screenshot from 2015-08-16 19 14 53
When Python mode is selected the actual size of statusPanel increases to accommodate the text like below
screenshot from 2015-08-16 19 15 32

This is causing the table to widen.

Member

Akarshit commented Aug 16, 2015

I think i was not able to express my self clearly.
When i select a contibution there is text displayed below the install button like below
screenshot from 2015-08-16 19 14 53
When Python mode is selected the actual size of statusPanel increases to accommodate the text like below
screenshot from 2015-08-16 19 15 32

This is causing the table to widen.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 16, 2015

Member

Why not set the maximum width of that JLabel (or whatever it is) to the width of the buttons?

Member

benfry commented Aug 16, 2015

Why not set the maximum width of that JLabel (or whatever it is) to the width of the buttons?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 20, 2015

Member

Fixed(?) with #3675

Member

benfry commented Aug 20, 2015

Fixed(?) with #3675

@benfry benfry closed this Aug 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment