New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM: Button formatting #3643

Closed
alignedleft opened this Issue Aug 16, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@alignedleft
Member

alignedleft commented Aug 16, 2015

The Install/Update/Remove buttons should match the design shown in the mockup as closely as possible. Changes I see that are needed:

  • buttons should be wider, to match the width of the Author column above
  • buttons need more internal padding, between the button edges and the image and text within each button
  • buttons should not have a drop shadow, only a thin, 1px border with rounded corners
  • buttons need the icons designed by James, as shown here (we already need other icons from him for #3478)
  • button vertical spacing should match the mockup, but that means the space below "Install" will disappear. Could the text and a progress bar that currently live here move below the "Remove" button? (Would this make sense in terms of UI?)

The current state:

screen shot 2015-08-16 at 3 01 49 pm

The mockup:

james s mockup

@alignedleft alignedleft added this to the 3.0 final milestone Aug 16, 2015

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Aug 18, 2015

Contributor

@alignedleft buttons are on the way.

Contributor

jamesjgrady commented Aug 18, 2015

@alignedleft buttons are on the way.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Aug 27, 2015

Member

@alignedleft In the third point

buttons should not have a drop shadow, only a thin, 1px border with rounded corners
This is the way OS renders buttons. I don't think that could be done away with without introducing inconsistency, because even if the button is changed it would be difficult to change the category dropdown.

Member

Akarshit commented Aug 27, 2015

@alignedleft In the third point

buttons should not have a drop shadow, only a thin, 1px border with rounded corners
This is the way OS renders buttons. I don't think that could be done away with without introducing inconsistency, because even if the button is changed it would be difficult to change the category dropdown.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Aug 27, 2015

Member

@Akarshit Thank you for asking about this. Please disregard point number 3 above. For now, let's use the standard (non-customized) buttons and dropdown UI elements (as you have it already). The alignment of things is more important than customizing their styling.

Please let me know if you have more questions about this!

Member

alignedleft commented Aug 27, 2015

@Akarshit Thank you for asking about this. Please disregard point number 3 above. For now, let's use the standard (non-customized) buttons and dropdown UI elements (as you have it already). The alignment of things is more important than customizing their styling.

Please let me know if you have more questions about this!

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 21, 2015

Member

I think I've fixed the remaining issues here this past weekend, and they'll be in 3.0 beta 7 (tweaked alignment, size, added 2x retina versions of the icons). If you find anything that's not done, let's open a new issues for specific problems.

Member

benfry commented Sep 21, 2015

I think I've fixed the remaining issues here this past weekend, and they'll be in 3.0 beta 7 (tweaked alignment, size, added 2x retina versions of the icons). If you find anything that's not done, let's open a new issues for specific problems.

@benfry benfry closed this Sep 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment