New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the debugger "break" on a blank line? #3765

Closed
shiffman opened this Issue Sep 4, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@shiffman
Member

shiffman commented Sep 4, 2015

I was doing a demonstration of the debugger today and got stuck on a certain point -- the sketch does not stop when a breakpoint is set on a blank line. In other words, the following works as expected with the sketch stopping on x = x + 1;.

screen shot 2015-09-04 at 4 20 52 pm

However, I was confused by the sketch never stopping with this scenario, a breakpoint set to a blank line.

screen shot 2015-09-04 at 4 21 44 pm

What is the correct / intended behavior?

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 5, 2015

Member

I suspect it can't stop where there's no code, but the correct behavior is probably that behind the scenes it sets the breakpoint for the line with code on it, or we don't allow breakpoints to be set for empty lines. The latter might be simpler.

Member

benfry commented Sep 5, 2015

I suspect it can't stop where there's no code, but the correct behavior is probably that behind the scenes it sets the breakpoint for the line with code on it, or we don't allow breakpoints to be set for empty lines. The latter might be simpler.

@benfry benfry closed this in 8738c92 Sep 11, 2015

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Sep 11, 2015

Member

In 3.0 beta 6, it won't set the breakpoint if the line contains no code.

Member

benfry commented Sep 11, 2015

In 3.0 beta 6, it won't set the breakpoint if the line contains no code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment