New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show usage..." does not locate keywords on correct line #3988

Closed
serebit opened this Issue Oct 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@serebit

serebit commented Oct 11, 2015

The orange highlight box also highlights the wrong section of code.

System: iMac Desktop (late 2011), OS X El Capitan
Build: 3.0 alpha

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 5, 2015

Contributor

Thanks! Looking into this.

Contributor

iamutkarshtiwari commented Nov 5, 2015

Thanks! Looking into this.

@serebit

This comment has been minimized.

Show comment
Hide comment
@serebit

serebit Nov 5, 2015

Also, sometimes error checking does not show the correct line, Rename
replaces the wrong keywords, and undoing Rename messes up the code further
by replacing only parts of the messed-up code.
On Thu, Nov 5, 2015 at 3:01 AM Utkarsh Tiwari notifications@github.com
wrote:

Looking into this.


Reply to this email directly or view it on GitHub
#3988 (comment)
.

serebit commented Nov 5, 2015

Also, sometimes error checking does not show the correct line, Rename
replaces the wrong keywords, and undoing Rename messes up the code further
by replacing only parts of the messed-up code.
On Thu, Nov 5, 2015 at 3:01 AM Utkarsh Tiwari notifications@github.com
wrote:

Looking into this.


Reply to this email directly or view it on GitHub
#3988 (comment)
.

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 7, 2015

Contributor

@Manindra29 There seems to be problem with ASTNodeWrapper. When we click on the 1st item in the "Usage of" window of "Show usage" option, it hightlights the correct location of the variable. But when we click the *_2nd* item, there is a difference of _7 indices between the _exact starting index_ and the _current starting index_ to be highlighted. Similarly all the items beyond and including 3rd item show a differnces of _14 indices_.

Contributor

iamutkarshtiwari commented Nov 7, 2015

@Manindra29 There seems to be problem with ASTNodeWrapper. When we click on the 1st item in the "Usage of" window of "Show usage" option, it hightlights the correct location of the variable. But when we click the *_2nd* item, there is a difference of _7 indices between the _exact starting index_ and the _current starting index_ to be highlighted. Similarly all the items beyond and including 3rd item show a differnces of _14 indices_.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment