New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution-manager: No visual feedback of update progress #4105

Open
mark-orion opened this Issue Nov 5, 2015 · 24 comments

Comments

Projects
None yet
7 participants
@mark-orion

mark-orion commented Nov 5, 2015

The contribution-manager should give visible feedback of the update progress. Currently updates appear in the "update" tab, but when clicking "update all" nothing seems to happen although in fact the download and installation runs hidden in the background.

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 11, 2015

Contributor

@alignedleft How to reproduce the situation when an update is available in Contribution Manager provided my installed contributions are already up-to-date ? I need to do this to add the above "visual update progress" features.

Contributor

iamutkarshtiwari commented Nov 11, 2015

@alignedleft How to reproduce the situation when an update is available in Contribution Manager provided my installed contributions are already up-to-date ? I need to do this to add the above "visual update progress" features.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 12, 2015

Member

@iamutkarshtiwari Good question. Can you save an older copy of a contribution (like a library) to keep around just for testing purposes?

Member

alignedleft commented Nov 12, 2015

@iamutkarshtiwari Good question. Can you save an older copy of a contribution (like a library) to keep around just for testing purposes?

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 12, 2015

Contributor

@alignedleft I dont have any older copy of any contribution because I recently setup my Processing build. Where can I find an older copy?

Contributor

iamutkarshtiwari commented Nov 12, 2015

@alignedleft I dont have any older copy of any contribution because I recently setup my Processing build. Where can I find an older copy?

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 12, 2015

Member

@iamutkarshtiwari I don't think we archive contributions anywhere. You would need to check the websites of various contributors to see if they archive older versions. For example, here are older copies of the official video library:

https://github.com/processing/processing-video/releases

Member

alignedleft commented Nov 12, 2015

@iamutkarshtiwari I don't think we archive contributions anywhere. You would need to check the websites of various contributors to see if they archive older versions. For example, here are older copies of the official video library:

https://github.com/processing/processing-video/releases

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz Nov 12, 2015

Member
Member

joelmoniz commented Nov 12, 2015

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari
Contributor

iamutkarshtiwari commented Nov 13, 2015

@alignedleft @joelmoniz thanks ! :)

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Nov 17, 2015

Member

@alignedleft Can we make some space to show a progress bar for all the contributions when the Update All button is clicked as some contributions are huge and take a lot of time to download. So i think a progress bar would be better than a spinner.
Currently the progress bar of update is shown when the contribution is selected in its respective tab after Update All button is clicked. Perhaps we can display it in the left most corner of the status panel.

Member

Akarshit commented Nov 17, 2015

@alignedleft Can we make some space to show a progress bar for all the contributions when the Update All button is clicked as some contributions are huge and take a lot of time to download. So i think a progress bar would be better than a spinner.
Currently the progress bar of update is shown when the contribution is selected in its respective tab after Update All button is clicked. Perhaps we can display it in the left most corner of the status panel.

iamutkarshtiwari added a commit to iamutkarshtiwari/processing that referenced this issue Nov 17, 2015

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 17, 2015

Member

@Akarshit This is a great idea. I can't trigger any updates on my end. If it's convenient, could you post a screenshot capturing the scenario you describe above? Then I can propose a more specific UI treatment. Thanks.

Member

alignedleft commented Nov 17, 2015

@Akarshit This is a great idea. I can't trigger any updates on my end. If it's convenient, could you post a screenshot capturing the scenario you describe above? Then I can propose a more specific UI treatment. Thanks.

@iamutkarshtiwari

This comment has been minimized.

Show comment
Hide comment
@iamutkarshtiwari

iamutkarshtiwari Nov 17, 2015

Contributor

@alignedleft @Akarshit If "download bar" sounds more interesting, I can implement that as well.

Contributor

iamutkarshtiwari commented Nov 17, 2015

@alignedleft @Akarshit If "download bar" sounds more interesting, I can implement that as well.

@mark-orion

This comment has been minimized.

Show comment
Hide comment
@mark-orion

mark-orion Nov 17, 2015

I want to throw my 5p in for the progress bar. As it has already been said: Downloads can take time - specially on a slow connection and I appreciate the work that is going on here!

mark-orion commented Nov 17, 2015

I want to throw my 5p in for the progress bar. As it has already been said: Downloads can take time - specially on a slow connection and I appreciate the work that is going on here!

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Nov 25, 2015

Member

@alignedleft I was working on this for a while and came up with a couple of designs

  1. Simply display the progressbar in the bottom left of the window.
    updates
  2. Display a circular progressbar in the status column of every contribution that is being installed/updated/removed. The circle will keep filling as the progress increases. The full progress bar is still in the status panel for the selected contribution.
    screenshot from 2015-11-26 00 45 18

There are advantages to the second method like

  1. The user would know what contribution are currently being installed/updated/removed.
  2. The user would know the progress of every contribution.

We can color code the circular progressbar for update/install/remove.

The above screenshot is from a initial imlementation, I will polish it once the UI is approved.

Member

Akarshit commented Nov 25, 2015

@alignedleft I was working on this for a while and came up with a couple of designs

  1. Simply display the progressbar in the bottom left of the window.
    updates
  2. Display a circular progressbar in the status column of every contribution that is being installed/updated/removed. The circle will keep filling as the progress increases. The full progress bar is still in the status panel for the selected contribution.
    screenshot from 2015-11-26 00 45 18

There are advantages to the second method like

  1. The user would know what contribution are currently being installed/updated/removed.
  2. The user would know the progress of every contribution.

We can color code the circular progressbar for update/install/remove.

The above screenshot is from a initial imlementation, I will polish it once the UI is approved.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 28, 2015

Member

@Akarshit Thanks! I like option 2, which, if I understand it, shows the progress of each individual update as well as the overall progress (such as when "update all" is triggered, and multiple updates are being processed at once).

What would option 2 look like on the "Updates" tab? (That is, if your first mockup was adapted for option 2.)

Member

alignedleft commented Nov 28, 2015

@Akarshit Thanks! I like option 2, which, if I understand it, shows the progress of each individual update as well as the overall progress (such as when "update all" is triggered, and multiple updates are being processed at once).

What would option 2 look like on the "Updates" tab? (That is, if your first mockup was adapted for option 2.)

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Nov 29, 2015

Member

@alignedleft Yes you are correct, the circular progress bar shows the progress of each individual update while the horizontal one shows the overall progress for the updates tab.
For the rest of the tab the circular shows the progress of individual install/remove/update and when a contribution is selected the status panel looks as in option 2 with the horizontal progress bar and percentage in number.

Would it make sense to show the percentage in center of the circular progress bar or will it be too much ?

Member

Akarshit commented Nov 29, 2015

@alignedleft Yes you are correct, the circular progress bar shows the progress of each individual update while the horizontal one shows the overall progress for the updates tab.
For the rest of the tab the circular shows the progress of individual install/remove/update and when a contribution is selected the status panel looks as in option 2 with the horizontal progress bar and percentage in number.

Would it make sense to show the percentage in center of the circular progress bar or will it be too much ?

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Nov 29, 2015

Member

@Akarshit I think no need to see the percentage.

I think we need @jamesjgrady to chime in here, as he is defining the voice of the new UI.

Member

alignedleft commented Nov 29, 2015

@Akarshit I think no need to see the percentage.

I think we need @jamesjgrady to chime in here, as he is defining the voice of the new UI.

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Dec 1, 2015

Contributor

@alignedleft @Akarshit I also like option 2. I can give you a refined comp if you still need it. Seems like the orange is not the right color and the type in Downloading is not right.

Contributor

jamesjgrady commented Dec 1, 2015

@alignedleft @Akarshit I also like option 2. I can give you a refined comp if you still need it. Seems like the orange is not the right color and the type in Downloading is not right.

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Dec 1, 2015

Member

@jamesjgrady A comp would be much appreciated. Thank you!

Member

alignedleft commented Dec 1, 2015

@jamesjgrady A comp would be much appreciated. Thank you!

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Dec 1, 2015

Member

@jamesjgrady Ya sure, a comp would be great :)

Member

Akarshit commented Dec 1, 2015

@jamesjgrady Ya sure, a comp would be great :)

@jamesjgrady

This comment has been minimized.

Show comment
Hide comment
@jamesjgrady

jamesjgrady Dec 7, 2015

Contributor

@alignedleft @Akarshit Here is what I was thinking for the progress bars (See comp). I like the idea of little bars next to the item that is getting updated. It provides more visual contrast than the circles but is still pretty subtle. It will also relate to the progress bar for "Installing", "Updating", and "Removing". The words should change with the button that has been activated from "Install" to "Installing", "Update" to "Updating" etc... Let me know if you have any questions. Thanks, James

151207-pf-contmgr-001

Contributor

jamesjgrady commented Dec 7, 2015

@alignedleft @Akarshit Here is what I was thinking for the progress bars (See comp). I like the idea of little bars next to the item that is getting updated. It provides more visual contrast than the circles but is still pretty subtle. It will also relate to the progress bar for "Installing", "Updating", and "Removing". The words should change with the button that has been activated from "Install" to "Installing", "Update" to "Updating" etc... Let me know if you have any questions. Thanks, James

151207-pf-contmgr-001

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Dec 8, 2015

Member

@jamesjgrady Oooh, this is really nice. I like the redundancy.

I understand from @benfry that we may not have full latitude in customizing the button elements (as you've done here), but the progress bars in the Status column are theoretically possible.

Member

alignedleft commented Dec 8, 2015

@jamesjgrady Oooh, this is really nice. I like the redundancy.

I understand from @benfry that we may not have full latitude in customizing the button elements (as you've done here), but the progress bars in the Status column are theoretically possible.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Dec 8, 2015

Member

@jamesjgrady @alignedleft I think we might need to expand the status column a little to make the progress bar look good in that, because in linux the progressbar comes with rounded edged by default so that requires a little bit more of space to display the progress along with the percentage.
I will do a mockup soon and post it here.

Member

Akarshit commented Dec 8, 2015

@jamesjgrady @alignedleft I think we might need to expand the status column a little to make the progress bar look good in that, because in linux the progressbar comes with rounded edged by default so that requires a little bit more of space to display the progress along with the percentage.
I will do a mockup soon and post it here.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Dec 11, 2015

Member

@alignedleft This is the how the CM looks with the default progress bars that are provided by java. Do you want me to customize them to look similar to those in the mockup above ?
screenshot from 2015-12-11 11 03 04

Member

Akarshit commented Dec 11, 2015

@alignedleft This is the how the CM looks with the default progress bars that are provided by java. Do you want me to customize them to look similar to those in the mockup above ?
screenshot from 2015-12-11 11 03 04

@alignedleft

This comment has been minimized.

Show comment
Hide comment
@alignedleft

alignedleft Dec 11, 2015

Member

@Akarshit Yes, please! If this is an insane amount of work, perhaps we can live without it. But ideally, the progress bars would:

  • be gray, not orange
  • mirror the typography (font and sizing) used in @jamesjgrady’s mockup

Also the Status column bar would have hard corners (not rounded).

The "Install" button progress bar would ideally be implemented within the button itself (or temporarily replacing the button), as in the mockup. If that's not possible, at least the styling should match the Status column progress bar, as described above.

Thank you for exploring this!

Member

alignedleft commented Dec 11, 2015

@Akarshit Yes, please! If this is an insane amount of work, perhaps we can live without it. But ideally, the progress bars would:

  • be gray, not orange
  • mirror the typography (font and sizing) used in @jamesjgrady’s mockup

Also the Status column bar would have hard corners (not rounded).

The "Install" button progress bar would ideally be implemented within the button itself (or temporarily replacing the button), as in the mockup. If that's not possible, at least the styling should match the Status column progress bar, as described above.

Thank you for exploring this!

benfry added a commit that referenced this issue Feb 14, 2016

Merge pull request #4154 from iamutkarshtiwari/feature-visualFeedback…
…OfUpdateProgress

Contribution-Manager: No visual feedback of update progress #4105
@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Feb 14, 2016

Member

Simple version from #4154 now merged for 3.0.2. Not quite the full download indicator thing, but it's a start.

Member

benfry commented Feb 14, 2016

Simple version from #4154 now merged for 3.0.2. Not quite the full download indicator thing, but it's a start.

@Akarshit

This comment has been minimized.

Show comment
Hide comment
@Akarshit

Akarshit Feb 29, 2016

Member

@benfry Should i continue working on #4229 or you have something else in mind?

Member

Akarshit commented Feb 29, 2016

@benfry Should i continue working on #4229 or you have something else in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment