New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo is a little "jerky" in insert mode #4302

Closed
joelmoniz opened this Issue Feb 15, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@joelmoniz
Member

joelmoniz commented Feb 15, 2016

Steps to reproduce the error:

  1. Enter some text
  2. Make the editor in Insert mode (by hitting the insert key)
  3. Type to overwrite text entered in 1.
  4. Undo

PS: I think I've identified the root of the issue. I should hopefully have a fix in soon.

@joelmoniz joelmoniz changed the title from Undo is a little to Undo is a little "jerky" in insert mode Feb 15, 2016

@benfry benfry added the help wanted label May 8, 2016

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry May 8, 2016

Member

Zero effort has been made to even make the editor compatible with insert mode, but contributions welcome.

Member

benfry commented May 8, 2016

Zero effort has been made to even make the editor compatible with insert mode, but contributions welcome.

@joelmoniz

This comment has been minimized.

Show comment
Hide comment
@joelmoniz

joelmoniz May 8, 2016

Member

Ah, I wasn't aware of that. Except for undo, though, insert mode seemed to work perfectly (although I don't think I tested all of its aspects, copy-paste being one of the first among these that come to mind, although I am not sure how pasting would work in this context, however). I think PR #4310 helped fix this particular issue though (although I didn't test other aspects of undo in insert mode or insert mode in general).

Member

joelmoniz commented May 8, 2016

Ah, I wasn't aware of that. Except for undo, though, insert mode seemed to work perfectly (although I don't think I tested all of its aspects, copy-paste being one of the first among these that come to mind, although I am not sure how pasting would work in this context, however). I think PR #4310 helped fix this particular issue though (although I didn't test other aspects of undo in insert mode or insert mode in general).

@benfry benfry closed this in #4310 May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment