New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move general PDE code from JavaMode into its own base classes #4606

Closed
benfry opened this Issue Aug 6, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@benfry
Member

benfry commented Aug 6, 2016

The side gradient and other basic handlers should live in processing.app not the JavaMode classes.

From the source:

We're overriding more things in JEditTextArea than we should, which makes it trickier for other Modes (Python, etc) to subclass because they'll need to re-implement what's in here, but first wade through it. To fix, we need to clean this up and put the appropriate cross-Mode changes into JEditTextArea (or a subclass in processing.app)

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 6, 2016

Contributor

Correct, there are bits of stuff here and there which need some cleaning. I didn't want to go down this rabbit hole last time because I was trying to focus on PDEX (and get it done).

Contributor

JakubValtar commented Aug 6, 2016

Correct, there are bits of stuff here and there which need some cleaning. I didn't want to go down this rabbit hole last time because I was trying to focus on PDEX (and get it done).

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 6, 2016

Member

Yup; not a critique—this is just moving my old TODO note from the top of the source into the issues list so that it's actually tracked.

I'm also looking at writing another Mode, so that's forcing the issue. I should have some fixes soon.

Member

benfry commented Aug 6, 2016

Yup; not a critique—this is just moving my old TODO note from the top of the source into the issues list so that it's actually tracked.

I'm also looking at writing another Mode, so that's forcing the issue. I should have some fixes soon.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Aug 6, 2016

Contributor

Not taken as a critique, I got a notification with you mentioning me and I was trying to answer that, though it seems you deleted it. Nevermind.

Contributor

JakubValtar commented Aug 6, 2016

Not taken as a critique, I got a notification with you mentioning me and I was trying to answer that, though it seems you deleted it. Nevermind.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 6, 2016

Member

Sorry for the confusion.

Member

benfry commented Aug 6, 2016

Sorry for the confusion.

@benfry

This comment has been minimized.

Show comment
Hide comment
@benfry

benfry Aug 6, 2016

Member

Fixed for the next release (3.2).

Member

benfry commented Aug 6, 2016

Fixed for the next release (3.2).

@benfry benfry closed this Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment