New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function result is ignored #4615

Closed
AppChecker opened this Issue Aug 13, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@AppChecker

AppChecker commented Aug 13, 2016

Hello!

Code in the method UrlHelper.getFileURI:

        extensions = extensionsList.split(",");
        for (String extension : extensions) {
            extension.trim().toLowerCase();
        }

ignores the return value of the String.toLowerCase method.

Probably, is should be:

extensions = extensionsList.split(",");
for (int i = 0; i < extensions.length; i++) {
    extensions[i] = extensions[i].trim().toLowerCase();
}

This possible defect found by static code analyzer AppChecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment