New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

println(int(byte(245))); throwing error #4652

Closed
x13420x opened this Issue Sep 7, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@x13420x

x13420x commented Sep 7, 2016

println(int(byte(245)));
Throws error _error in"byte"_
but it does seem to work
this error has existed for at least 3 months now

@JakubValtar JakubValtar self-assigned this Sep 25, 2016

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Sep 25, 2016

Contributor

Hi @x13420x, thanks for the report! We'll fix it.

Note for myself: SourceUtils.java, TYPE_CONSTRUCTOR_REGEX does not handle two immediately following type constructors without any other character in between, because last non-capturing group of the first match overlaps with the first non-caturing group of the next potential match. TODO: Figure out how to get around this or run the regex multiple times.

Contributor

JakubValtar commented Sep 25, 2016

Hi @x13420x, thanks for the report! We'll fix it.

Note for myself: SourceUtils.java, TYPE_CONSTRUCTOR_REGEX does not handle two immediately following type constructors without any other character in between, because last non-capturing group of the first match overlaps with the first non-caturing group of the next potential match. TODO: Figure out how to get around this or run the regex multiple times.

@x13420x

This comment has been minimized.

Show comment
Hide comment
@x13420x

x13420x Sep 27, 2016

It wasn`t doing this on P3.02 It started with the mothers day p3.10

x13420x commented Sep 27, 2016

It wasn`t doing this on P3.02 It started with the mothers day p3.10

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Sep 27, 2016

Contributor

That's correct, we got a new error checker in 3.1 :)

Contributor

JakubValtar commented Sep 27, 2016

That's correct, we got a new error checker in 3.1 :)

JakubValtar added a commit to JakubValtar/processing that referenced this issue Nov 16, 2016

Fix nested type constructors raising error
Replace non-capturing groups by positive lookahead and lookbehind,
because they don't consume the source String and allow for first and
last group to overlap when two constructors are directly nested.

Fixes #4652

@benfry benfry closed this in #4744 Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment