New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL shader regex bug #4810

Closed
neilcsmith-net opened this Issue Jan 5, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@neilcsmith-net

neilcsmith-net commented Jan 5, 2017

There seems to be a bug in the regex for updating GLSL code, which breaks the default texture rectangle shader. I think textureRect should be texture2DRect in https://github.com/processing/processing/blob/master/core/src/processing/opengl/PGL.java#L1957

Noticed this while having a look at what might be involved in getting Syphon to work.

@JakubValtar

This comment has been minimized.

Show comment
Hide comment
@JakubValtar

JakubValtar Jan 6, 2017

Contributor

You're right. My bad, I left it out when rewriting preprocessor into regex. https://github.com/processing/processing/pull/4052/files#diff-88c7dd4e8f37672d20e228a71a433a6dL1889

Contributor

JakubValtar commented Jan 6, 2017

You're right. My bad, I left it out when rewriting preprocessor into regex. https://github.com/processing/processing/pull/4052/files#diff-88c7dd4e8f37672d20e228a71a433a6dL1889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment