Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added Present's background color as an option to the Preferences window. #2568
In these few commits, I've added an option for the user to conveniently choose a background color for Present from the Preferences window. This can be done in 2 ways:
The text field has been designed to accept a hex color of the form #xxxxxx and xxxxxx, (x- 0 to F), and auto-previews the color once the user enters a valid hex color.
A Cancel button has also been added to the ColorChooser, because it seemed like a nice feature to have for both the Color Selector tool, as well as for this particular application.
Ben, it's a bit unclear to us how we should proceed. I propose:
Perhaps I'm just confused by the commit. It looks like an entire new color chooser class has been added and removed. Or maybe there's a line endings problem that makes this look much larger?
Check out the links for those commits... Maybe it's just a matter of re-doing the pull request so that I can see what's actually going on?
Oh, you are looking at every single commit. That is not needed, just click "Files changed" at the top, that gives you the changes that will be applied in relation to the current code.
And yes, Joel initially duplicated the color chooser and i asked him to reuse the one we already had instead. So it is actually not that much change in total.
We can even slim it down further and make the style be concise if we make ColorPreference into a full class and use that instead of our own custom items. Should we do that?