New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties file no longer overwritten with contributions.txt values unless something in the properties is amiss #2608

Merged
merged 1 commit into from Jul 25, 2014

Conversation

Projects
None yet
2 participants
@joelmoniz
Copy link
Member

joelmoniz commented Jun 23, 2014

All that this involved was to check if the present properties were valid or not, and replace all those that aren't (Eg: null or empty or not a non-integer in a field that is supposed to be for an integer, like version) with the corresponding vlue of the field from the contributions.txt file.

Thus, (out-of-date) values from contributions.txt no longer overwrite valid values in the properties file.

This commit fixes Issue #2572.

Props file no longer overwritten with contribs.txt
Unless something isn't right, in which case only that field is overwritten
in properties
@benfry

This comment has been minimized.

Copy link
Member

benfry commented Jul 25, 2014

Hm, ok... this was an intentional design decision, however, so that a poorly written .properties file didn't break the environment. Probably better to disable it for now, but we need a better solution.

benfry added a commit that referenced this pull request Jul 25, 2014

Merge pull request #2608 from joelmoniz/fixContribProp
Properties file no longer overwritten with contributions.txt values unless something in the properties is amiss

@benfry benfry merged commit cd42f8f into processing:master Jul 25, 2014

@joelmoniz joelmoniz deleted the joelmoniz:fixContribProp branch Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment