New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help>References and Help>Environment open in default browser in Windows #2657

Merged
merged 1 commit into from Jul 28, 2014

Conversation

Projects
None yet
2 participants
@joelmoniz
Copy link
Member

joelmoniz commented Jul 27, 2014

This fixes #2656

@benfry

This comment has been minimized.

Copy link
Member

benfry commented Jul 28, 2014

What does this change? getCanonicalFile() doesn't really do much. What do you mean by "default browser"?

@joelmoniz

This comment has been minimized.

Copy link
Member

joelmoniz commented Jul 28, 2014

This makes a file whose path is like

C:/processing/app/bin/../../build/windows/work/modes/java/reference/index.html

into a file with the path

C:/processing/build/windows/work/modes/java/reference/index.html

This seems to solve the Windows specific issue where the Desktop.getDesktop().browse(URI uri) function fails without affecting Linux atleast (pretty sure it won't affect OS X either, since the 2 files are effectively the same).

By default browser, I meant that the Desktop.getDesktop().browse(URI uri) function, which is supposed to open the file in the browser, fails to do so.

@benfry

This comment has been minimized.

Copy link
Member

benfry commented Jul 28, 2014

Sorry, I know what getCanonicalFile() does, it just didn't make sense in this context. My question was "why would using that fix the default browser"?

I didn't understand from your report that the browser was failing to load—it sounded like your problem was that it was using the "default" browser instead of something else that you wanted. Makes more sense from your description.

benfry added a commit that referenced this pull request Jul 28, 2014

Merge pull request #2657 from joelmoniz/fixReferenceNotShowing
Help>References and Help>Environment open in default browser in Windows

@benfry benfry merged commit 25d5f31 into processing:master Jul 28, 2014

@joelmoniz joelmoniz deleted the joelmoniz:fixReferenceNotShowing branch Dec 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment